Page MenuHomePhabricator
Create Task
Maniphest T104045

extensions/Wikidata - file permissions trigger debian lintian warnings
Closed, InvalidPublic
Actions

Description

0. Context

DEB packages of mediawiki and many of its extensions, are prepared as part of the WP-MIRROR project.
See https://www.mediawiki.org/wiki/Wp-mirror.

  1. Lintian

During the build process, lintian performs a great number of sanity checks, including seeing if each file has file permissions appropriate to its file type.

When lintian sees a non-executable file with 755 permissions, rather than 644, lintian will throw a warning like:

W: wp-mirror-mediawiki: executable-not-elf-or-script usr/share/wp-mirror-mediawiki/extensions/Wikidata/extensions/Constraints/includes/ConstraintCheck/Checker/CommonsLinkChecker.php

When lintian sees an executable file with 644 permissions, rather than 755, lintian will throw a warning like:

W: wp-mirror-mediawiki-extensions: script-not-executable usr/share/wp-mirror-mediawiki/extensions/Wikidata/extensions/Constraints/build/travis/after_script.sh

  1. Files which should have permissions set to 644
  1. Files which should have permissions set to 755

Wikidata/extensions/PropertySuggester/build/travis/after_script.sh
Wikidata/extensions/PropertySuggester/build/travis/before_script.sh
Wikidata/extensions/PropertySuggester/build/travis/script.sh
Wikidata/extensions/Wikibase/build/jenkins/mw-apply-wb-settings.sh
Wikidata/extensions/Wikibase/build/travis/install.sh
Wikidata/extensions/Wikibase/build/travis/mw-apply-wb-settings.sh
Wikidata/extensions/Wikibase/build/travis/script.sh
Wikidata/extensions/Wikibase/build/travis/update-db.sh
Wikidata/vendor/data-values/data-types/build/travis/script.sh
Wikidata/vendor/wikibase/data-model-javascript/build/travis/script.sh
Wikidata/vendor/wikibase/serialization-javascript/build/travis/script.sh

  1. Technical details

DEB standards version: 3.9.6
GIT branch: master

The files under 3. have their executable stripped because composer extracted them from a zip archive that misses that bit. The original repos have the permission bit on these files.

Details

SubjectRepoBranchLines +/-
Remove executable bit from files that are notmediawiki/extensions/WikibaseQualitymaster+0 -0
Remove executable flag from regular PHP filemediawiki/extensions/Wikibasemaster+0 -0
Remove executable bit from files that are notmediawiki/extensions/WikibaseQualityConstraintsmaster+0 -0
Remove executable bit from files that are notmediawiki/extensions/WikibaseQualityExternalValidationmaster+0 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

wpmirrordev created this task.Jun 27 2015, 1:55 AM
wpmirrordev assigned this task to Wikidata-bugs.
wpmirrordev raised the priority of this task from to Medium.
wpmirrordev updated the task description. (Show Details)
wpmirrordev added projects: Wikidata, good first task.
wpmirrordev subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2015, 1:55 AM
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Jun 28 2015, 4:54 PM
gerritbot subscribed.Jul 23 2015, 8:35 PM

Change 226620 had a related patch set uploaded (by JanZerebecki):
Remove executable flag from regular PHP file

https://gerrit.wikimedia.org/r/226620

gerritbot added a project: Patch-For-Review.Jul 23 2015, 8:35 PM
JanZerebecki lowered the priority of this task from Medium to Lowest.Jul 23 2015, 8:40 PM
JanZerebecki set Security to None.
JanZerebecki subscribed.Jul 23 2015, 8:43 PM

composer uses zip files which drop the executable bit, which explains why the .sh scripts from Wikibase don't have it anymore. It is set in the Wikibase repo.
Anyway not sure if creating a deb from the build (the Wikidata extension) makes sense, but in the long run the build will hopefully go away.

gerritbot added a comment.Jul 23 2015, 8:48 PM

Change 226624 had a related patch set uploaded (by JanZerebecki):
Remove executable bit from files that are not

https://gerrit.wikimedia.org/r/226624

gerritbot added a comment.Jul 23 2015, 8:57 PM

Change 226629 had a related patch set uploaded (by JanZerebecki):
Remove executable bit from files that are not

https://gerrit.wikimedia.org/r/226629

gerritbot added a comment.Jul 23 2015, 9:00 PM

Change 226631 had a related patch set uploaded (by JanZerebecki):
Remove executable bit from files that are not

https://gerrit.wikimedia.org/r/226631

gerritbot added a comment.Jul 23 2015, 9:12 PM

Change 226631 merged by jenkins-bot:
Remove executable bit from files that are not

https://gerrit.wikimedia.org/r/226631

gerritbot added a comment.Jul 23 2015, 10:06 PM

Change 226629 merged by jenkins-bot:
Remove executable bit from files that are not

https://gerrit.wikimedia.org/r/226629

gerritbot added a comment.Jul 23 2015, 10:14 PM

Change 226620 merged by jenkins-bot:
Remove executable flag from regular PHP file

https://gerrit.wikimedia.org/r/226620

JanZerebecki mentioned this in rMEXT073838c8db99: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jul 23 2015, 10:14 PM
Addshore mentioned this in rEWBAd707ba8c93df: Remove executable flag from regular PHP file.Jul 23 2015, 10:14 PM
gerritbot added a comment.Jul 23 2015, 10:33 PM

Change 226624 merged by jenkins-bot:
Remove executable bit from files that are not

https://gerrit.wikimedia.org/r/226624

JanZerebecki updated the task description. (Show Details)Jul 23 2015, 10:39 PM
JanZerebecki removed projects: Patch-For-Review, good first task.
JanZerebecki updated the task description. (Show Details)
JanZerebecki moved this task from ready to go to hold on the Wikidata board.
JanZerebecki added a comment.Jul 23 2015, 10:43 PM

If T95663 is done then the Wikidata repository will be abandoned.

wpmirrordev updated the task description. (Show Details)Sep 22 2015, 11:00 PM
wpmirrordev added a comment.Sep 22 2015, 11:06 PM

Task description was updated due to appearance of files with inappropriate permissions seen in the latest git pull.
In particular, new files with paths like Wikidata/extensions/ExternalValidation/* should be reviewed.

JanZerebecki closed subtask T113751: correct executable bit on files in Quality extensions as Resolved.Oct 1 2015, 12:34 PM
wpmirrordev mentioned this in T113751: correct executable bit on files in Quality extensions.Oct 1 2015, 6:14 PM
wpmirrordev updated the task description. (Show Details)Oct 1 2015, 6:17 PM
wpmirrordev added a comment.Oct 1 2015, 6:19 PM

I updated the task description to reflect the closure of T113751, which cured the debian lintian warnings caused by Wikidata/extensions/ExternalValidation/* files.

wpmirrordev updated the task description. (Show Details)Oct 3 2015, 12:07 AM

I updated the task description to reflect closure of T113751, which cured the debian lintian warnings caused by Wikidata/extensions/Constraints/* and Wikidata/extensions/Quality/* files.

Addshore mentioned this in T173818: [Epic] Kill the Wikidata build step.Aug 23 2017, 1:38 PM
Addshore added a parent task: T181709: Cleanup Phabricator tickets once the build is dead.Nov 30 2017, 12:36 PM
Addshore closed this task as Invalid.Dec 1 2017, 7:22 PM
Addshore subscribed.

Closing this as the repo is now not used / should be archived.

And if anything using it throws warnings or errors it should stop using it.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL