Page MenuHomePhabricator

Two getLink functions in same file is confusing
Closed, ResolvedPublic

Description

Please do not reuse the names of functions in the same file, because it is confusing. In ext.cx.tools.link there are global getLink and CXLink.prototype.getLink.

Event Timeline

Nikerabbit updated the task description. (Show Details)
Nikerabbit raised the priority of this task from to Normal.
Nikerabbit assigned this task to santhosh.

Change 221565 had a related patch set uploaded (by Santhosh):
Rename the getLink method to avoid confusion with CXLink.getLink

https://gerrit.wikimedia.org/r/221565

Change 221565 merged by jenkins-bot:
Rename the getLink method to avoid confusion with CXLink.getLink

https://gerrit.wikimedia.org/r/221565

Nikerabbit closed this task as Resolved.Jun 29 2015, 7:38 PM