Regression: Add to collection dialog does not show all collections
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• bmansurov
	Jun 29 2015, 10:31 AM

Description

Steps to reproduce:

Make sure you have more than 50 collections.
Visit a page (say, /wiki/1) and click on the watchstar icon.
Scroll the list of collections (under the title 'Add to existing collection') in the dialog that appears.
You'll only see 50 collections.

Expected:

You should be able to load and see other collections (via infinite scroll).

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Allow user to add to more than 50 collections from page	mediawiki/extensions/Gather	master	+16 -5

Customize query in gerrit

Related Objects

Mentioned In: rEGAT2122b83e12b2: Allow user to add to more than 50 collections from page
rMEXTc2fdb2c14921: Updated mediawiki/extensions Project: mediawiki/extensions/Gather…

Event Timeline

• bmansurov created this task.Jun 29 2015, 10:31 AM

• bmansurov raised the priority of this task from to Needs Triage.

• bmansurov updated the task description. (Show Details)

• bmansurov added a project: Web-Team-Backlog-Archived.

• bmansurov subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2015, 10:31 AM

@bmansurov: Is this about the Gather code project? If so please add it so people can find this bug when looking for bugs in Gather.

• bmansurov added a project: Gather.Jun 29 2015, 11:05 AM

• bmansurov set Security to None.

• KLans_WMF triaged this task as Medium priority.Jun 29 2015, 5:11 PM

There should be a more link.
A casual glance shows the more link is enabled when resp.continueArgs is present in getCurrentUsersCollections so I suspect pagination changes may have broken it and we missed it.

• KLans_WMF added a project: Reading-Web-Sprint-50-The-X-Files.Jul 1 2015, 5:12 PM

• KLans_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-50-The-X-Files board.

• KLans_WMF moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog-Archived board.Jul 1 2015, 5:27 PM

Jdlrobson claimed this task.Jul 1 2015, 9:23 PM

Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-50-The-X-Files board.

Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-50-The-X-Files board.Jul 1 2015, 10:08 PM

Change 222196 had a related patch set uploaded (by Jdlrobson):
Allow user to add to more than 50 collections from page

https://gerrit.wikimedia.org/r/222196

gerritbot added a project: Patch-For-Review.Jul 1 2015, 10:13 PM

• Jhernandez removed a project: Web-Team-Backlog-Archived.Jul 2 2015, 9:51 AM

Change 222196 merged by jenkins-bot:
Allow user to add to more than 50 collections from page

https://gerrit.wikimedia.org/r/222196

• Konfused-Kitten mentioned this in rMEXTc2fdb2c14921: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Jul 2 2015, 12:57 PM

phuedx mentioned this in rEGAT2122b83e12b2: Allow user to add to more than 50 collections from page.Jul 2 2015, 12:58 PM

phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-50-The-X-Files board.Jul 2 2015, 1:04 PM

Verified on BC.

I noticed a bug in the associated browser tests, which I've fixed here: https://gerrit.wikimedia.org/r/#/c/222578/

phuedx closed this task as Resolved.Jul 3 2015, 12:50 PM

phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-50-The-X-Files board.

phuedx removed a project: Patch-For-Review.Jul 6 2015, 6:49 PM

• bmansurov unsubscribed.Jul 7 2015, 10:06 AM

Regression: Add to collection dialog does not show all collectionsClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Regression: Add to collection dialog does not show all collections
Closed, ResolvedPublic
Actions