Page MenuHomePhabricator

Do not double decode HTML entities in indicator ID
Closed, ResolvedPublic

Description

Currently the entities in the indicator name gets double decoded

<indicator name="1&2&amp;3&amp;amp;4&amp;amp;amp;5">Indicator</indicator>

gets rendered to

<div class="mw-indicator" id="mw-indicator-1.262.263.264.26amp.3B5">Indicator</div>

Expected result:

<div class="mw-indicator" id="mw-indicator-1.262.263.26amp.3B4.26amp.3Bamp.3B5">Indicator</div>

Event Timeline

Fomafix created this task.Jun 29 2015, 1:18 PM
Fomafix claimed this task.
Fomafix raised the priority of this task from to Low.
Fomafix updated the task description. (Show Details)
Fomafix added a project: MediaWiki-Parser.
Fomafix added a subscriber: Fomafix.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2015, 1:18 PM

Change 221614 had a related patch set uploaded (by Gerrit Patch Uploader):
Do not double decode HTML entities in indicator ID

https://gerrit.wikimedia.org/r/221614

Change 286385 had a related patch set uploaded (by Gerrit Patch Uploader):
Do not double decode HTML entities for IDs

https://gerrit.wikimedia.org/r/286385

With https://gerrit.wikimedia.org/r/362167 I added parser tests that test for the current behavior.

The HTML of indicator is not in the parser output so it can not tested with the parser tests. I removed the tests from https://gerrit.wikimedia.org/r/362167.

With https://gerrit.wikimedia.org/r/362335 I added parser tests that test for the current behavior.

Change 221614 abandoned by Fomafix:
Do not double decode HTML entities for IDs

Reason:
Superseded by https://gerrit.wikimedia.org/r/286385.

https://gerrit.wikimedia.org/r/221614

Change 286385 merged by jenkins-bot:
[mediawiki/core@master] Do not double decode HTML entities for IDs

https://gerrit.wikimedia.org/r/286385

Fomafix closed this task as Resolved.Oct 4 2017, 7:32 AM
Fomafix removed a project: Patch-For-Review.