Page MenuHomePhabricator
Create Task
Maniphest T104213

No icon for "View source" and "Edit" in sidebar
Closed, ResolvedPublic
Actions

Assigned To
Volker_E
Authored By
Glaisher
Jun 29 2015, 5:02 PM
Tags
Referenced Files
F2968417: T104213-Blueprint-Edit-Link.png
Nov 16 2015, 11:29 PM
F2644370: icon.png
Sep 29 2015, 6:12 AM
F351769: uniE222 - editLock.svg
Aug 3 2015, 8:18 PM
F184957: bluespice.png
Jun 29 2015, 5:02 PM
Subscribers
Aklapper
gerritbot
Glaisher
Pastakhov
• Prtksxna
• violetto

Description

bluespice.png (186×370 px, 7 KB)
T104213-Blueprint-Edit-Link.png (411×372 px, 18 KB)
See attached screenshot. There is no icon next the the "View source". I don't know whether this is intentional or not but it currently looks very weird when there is no icon for "View source" but present for the other links.

Details

SubjectRepoBranchLines +/-
Add icon for 'View Source' menu itemmediawiki/skins/Blueprintmaster+31 -8
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 Resolved• SpageT307 Announcing the Developer Hub prototype release
 Resolved• SpageT299 Release the Developer Hub prototype
 Resolved• SpageT306 Featuring the first three APIs in the Developer Hub
 ResolvedoriT334 Document RCStream in the Developer Hub
 DeclinedNoneT302 API sandboxes for the Developer Hub
 ResolvedNoneT300 Select the three APIs featured at the Developer Hub prototype
 DeclinedNoneT88755 Improve MediaWiki API example behavior
 ResolvedAnomieT89229 API Help should generate [try in ApiSandbox] link to Special:ApiSandbox#action=params from getExamples()
 DeclinedNoneT89318 Replace on-wiki API documentation with Special:ApiHelp transclusion
 OpenNoneT89768 Language support in Special:ApiHelp and its transclusion.
 OpenNoneT90528 Generated API Help doesn't indicate the MediaWiki versions that support a module and parameters.
 Resolved• SpageT89680 Template:ApiEx on mw.org should have a link to "[view in ApiSandbox]".
 DeclinedNoneT335 Document the Content API in the Developer Hub
 ResolvedjeropbrendaT359 Document the Wikidata API in the Developer Hub
 OpenNoneT89863 [Task] Merge on-wiki Wikibase/API documentation into Wikibase apihelp strings.
 DeclinedQgilT303 Setup the Developer Hub prototype
 Resolved• SpageT98164 prototype Data and developer hub with Blueprint skin
 ResolvedQgilT101099 Developer Relations Roadmap
 ResolvedQgilT113030 Developer Relations quarterly review Jul-Sep 2015
 ResolvedQgilT101100 Engineering Community quarterly goals for July-September 2015
 Resolved• SpageT101441 Goal: Integrate the new Web APIs hub with mediawiki.org
 Resolved• SpageT305 Developer Hub homepage
 Resolved• SpageT301 Define the look&feel of the Developer Hub
 DeclinedNoneT93062 Define the navigation elements of the Web APIs hub
 DeclinedNoneT317 "Terms of Use" must be prominently featured in the Developer Hub
 Resolved• SpageT92941 Define personas for dev.wikimedia.org
 Resolved• SpageT92945 Reflect in dev.wikimedia.org what Wikimedia offers to developers
 DeclinedNoneT93610 Put WikimediaUI Style Guide on mediawiki.org
 DeclinedNoneT93613 Deploy Blueprint on mediawiki.org as optional and experimental skin
 DeclinedNoneT113208 Consolidate CSS background images implementation with core mixins or ResourceLoaderImageModule
 ResolvedVolker_ET104213 No icon for "View source" and "Edit" in sidebar

Event Timeline

Glaisher created this task.Jun 29 2015, 5:02 PM
Glaisher raised the priority of this task from to Needs Triage.
Glaisher updated the task description. (Show Details)
Glaisher added a project: Blueprint.
Glaisher subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2015, 5:02 PM
• Prtksxna triaged this task as Medium priority.Jul 3 2015, 4:36 AM
Volker_E assigned this task to • violetto.Aug 3 2015, 6:55 PM
Volker_E claimed this task.
Volker_E set Security to None.
Volker_E added a subscriber: • violetto.
Volker_E added a subscriber: • Prtksxna.
Volker_E added a comment.Aug 3 2015, 6:58 PM

@violetto Are the icons already somewhere? There's also the 'Edit' link missing an icon, see https://livingstyleguide.wmflabs.org/wiki/Checks,_radios_and_toggles

• violetto added a comment.Aug 3 2015, 8:18 PM

View source is put in place where "Edit" or "Edit source" is disabled. View source lets you view the source, just like you would when you click on edit, but without the ability to edit.

What do you think about using this icon:

uniE222 - editLock.svg1 KBDownload

@Volker_E, icons are already within the oojs library.

We don't yet have a finished "Edit" (with VE) icon.

Volker_E moved this task from Backlog to Next Up on the Blueprint board.Aug 30 2015, 3:25 AM
Volker_E added a comment.EditedSep 14 2015, 1:03 AM

@violetto I think that's a very nice icon on a big size, for 24x24 px size I'm wondering about the significance/clarity of both symbols (edit pencil and lock icon) together.

Pastakhov subscribed.Sep 29 2015, 6:12 AM

+1, It's nice for me

icon.png (248×493 px, 11 KB)

gerritbot subscribed.Nov 13 2015, 7:35 PM

Change 252973 had a related patch set uploaded (by VolkerE):
Add icon for 'View Source' menu item

https://gerrit.wikimedia.org/r/252973

gerritbot added a project: Patch-For-Review.Nov 13 2015, 7:36 PM
Volker_E moved this task from Next Up to Needs Review / Feedback on the Blueprint board.Nov 13 2015, 7:37 PM
Volker_E added a parent task: T113208: Consolidate CSS background images implementation with core mixins or ResourceLoaderImageModule.
Volker_E renamed this task from No icon for "View source" in sidebar to No icon for "View source" and "Edit" in sidebar.Nov 16 2015, 7:02 PM
Volker_E moved this task from Needs Review / Feedback to In Development on the Blueprint board.Nov 16 2015, 10:04 PM
Volker_E added a comment.Nov 16 2015, 10:26 PM

@violetto what is the "Edit" vs "Edit source" icon?

Volker_E updated the task description. (Show Details)Nov 16 2015, 11:29 PM
• Prtksxna added a comment.Nov 17 2015, 10:55 AM
In T104213#1809254, @Volker_E wrote:

@violetto what is the "Edit" vs "Edit source" icon?

I don't think View and View source map to Edit and Edit source. One can argue that they somewhat do, but…

In my understanding:

Volker_E added a comment.Nov 17 2015, 7:24 PM

@Prtksxna I was a bit sloppy in my words. "Bearbeiten" translates to "Edit" and it misses an icon currently. So my short sentence meant @violetto what's the Edit icon versus the Edit source icon? Latter has an edit icon specified currently as seen in screenshot above with German settings.

Volker_E added a comment.Dec 14 2015, 10:23 PM

It seems promising, that we will see just one "Edit" link in near future, looking at progress over at T58337: Change VE integration to only use one edit tab, to avoid user choice paralysis.

Volker_E moved this task from In Development to Needs Review / Feedback on the Blueprint board.Dec 14 2015, 10:23 PM
Volker_E added a parent task: T93613: Deploy Blueprint on mediawiki.org as optional and experimental skin.Dec 15 2015, 2:21 AM
Volker_E added a comment.Dec 15 2015, 8:08 PM

It seems promising, that we will see just one "Edit" link in near future, looking at progress over at T58337: Change VE integration to only use one edit tab, to avoid user choice paralysis. We'll have to revisit this task (or opening a follow-up) then.

gerritbot added a comment.Dec 16 2015, 3:01 AM

Change 252973 merged by jenkins-bot:
Add icon for 'View Source' menu item

https://gerrit.wikimedia.org/r/252973

Volker_E closed this task as Resolved.Dec 16 2015, 7:18 AM
Volker_E moved this task from Needs Review / Feedback to Done on the Blueprint board.
Volker_E removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL