Page MenuHomePhabricator

OOUI should have a mediawiki.ui-compatible skin for dialogs
Closed, InvalidPublic

Description

This is how the OAuth authentication form looks with JS disabled (ie. falling back to a PHP-generated HTML form - whether with plain HtmlForm or OOUIHtmlForm as in 201230 does not make much difference):


This is compatible with how other MediaWiki forms/interfaces look and with the style guide for buttons.

This is how it looks with JS enabled, using the OOUI MessageDialog (via 201230):


The button layout is completely alien from the rest of MediaWiki, even though the classes generated on the buttons are the same.

Event Timeline

Tgr created this task.Jun 30 2015, 1:00 AM
Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added projects: OOUI, UI-Standardization.
Tgr added a subscriber: Tgr.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 30 2015, 1:00 AM
Tgr updated the task description. (Show Details)
Tgr set Security to None.
Jdforrester-WMF closed this task as Invalid.Sep 18 2015, 8:25 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

I'm completely lost. Why on Earth are you using a MessageDialog if you want a page-level flow?

By definition, OOUI's MediaWiki theme is meant to replace MWUI, and so is 'compatible'.

Tgr added a subscriber: matmarex.Sep 18 2015, 9:25 PM

Not sure what you mean by page-level flow. This is how the authentication page looks:


In terms of control flow this could be called a normal page (there is just a form with some buttons; if you click any of the buttons, the form is submitted and you are redirected) but it looks like a message dialog (and is in fact implemented with one, but using a heavily customized jQuery UI, which we want to get rid of).

This is in line with the design guidelines of button styling and intention colors (I am linking to the mw.ui living styleguide because the other one is broken but they look very similar). The OOUI MessageDialog is not.

@matmarex recommended creating a custom Dialog subclass for OAuth, which is probably something necessary anyway, because the final design is supposed to be a lot more complex (F115139 - ignore the part where it is its own weird page thing). So this task is not really relevant for OAuth anymore. It would still be good IMO if MessageDialog had the same button styles that everything else has.

Created T113099 for the OAuth use case (hopefully with a less confusing description, sorry about that).

Danny_B moved this task from Unsorted to OOUI on the UI-Standardization board.May 20 2016, 8:58 PM