Page MenuHomePhabricator
Create Task
Maniphest T104330

ParseValue API module should optionally trigger validation
Closed, ResolvedPublic1 Estimated Story Points
Actions

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add optional validation to wbparsevaluemediawiki/extensions/Wikibasemaster+195 -21
Add optional validation to ParseValue apimediawiki/extensions/Wikibasemaster+154 -24
Add ValueValidatorFactory & Testsmediawiki/extensions/Wikibasemaster+162 -0
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
OpenNoneT104331 [Task] Value preview should tell the backend to validate the user input
ResolvedAddshoreT104862 [Bug] Date input parses YYYY MM DD as CURDAY CURMONTH YYYY or not at all
ResolvedTobi_WMDE_SWT92619 make Wikidata browsertests non-flaky (tracking)
ResolveddanielT104330 ParseValue API module should optionally trigger validation
ResolveddanielT104876 wbparsevalue should use datatype to identify parser
· · ·

Event Timeline

Tobi_WMDE_SW created this task.Jun 30 2015, 1:25 PM
Tobi_WMDE_SW raised the priority of this task from to High.
Tobi_WMDE_SW updated the task description. (Show Details)
Tobi_WMDE_SW added projects: DataValues, MediaWiki-extensions-Wikibase-Repo, Wikidata, Wikidata-Sprint-2015-06-30.
Tobi_WMDE_SW added subscribers: Jc3s5h, Lydia_Pintscher, daniel and 5 others.
Tobi_WMDE_SW set Security to None.Jun 30 2015, 2:07 PM
Tobi_WMDE_SW edited a custom field.
Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Jul 2 2015, 2:13 PM
gerritbot subscribed.Jul 3 2015, 11:10 AM

Change 222564 had a related patch set uploaded (by Addshore):
Add ValueValidatorFactory & Tests

https://gerrit.wikimedia.org/r/222564

gerritbot added a project: Patch-For-Review.Jul 3 2015, 11:10 AM

Change 222565 had a related patch set uploaded (by Addshore):
Add optional validation to ParseValue api

https://gerrit.wikimedia.org/r/222565

daniel moved this task from Backlog to Doing on the Wikidata-Sprint-2015-06-30 board.Jul 6 2015, 3:50 PM
daniel removed a subtask: T104331: [Task] Value preview should tell the backend to validate the user input.
daniel added a parent task: T104331: [Task] Value preview should tell the backend to validate the user input.
daniel claimed this task.Jul 6 2015, 3:52 PM
daniel removed a parent task: T102930: [Bug] Entering times used to be blocked with "not supported" but is not any more.

Adam said he isn't happy with his patch. I'll work on this over the next days.

daniel mentioned this in T104331: [Task] Value preview should tell the backend to validate the user input.Jul 6 2015, 5:08 PM
gerritbot added a comment.Jul 6 2015, 10:11 PM

Change 223192 had a related patch set uploaded (by Daniel Kinzler):
Add optional validation to wbparsevalue

https://gerrit.wikimedia.org/r/223192

daniel moved this task from Doing to Review on the Wikidata-Sprint-2015-06-30 board.Jul 7 2015, 10:03 PM
gerritbot added a comment.Jul 9 2015, 9:27 AM

Change 222564 abandoned by Addshore:
Add ValueValidatorFactory & Tests

Reason:
Abandon per daniels alternative

https://gerrit.wikimedia.org/r/222564

gerritbot added a comment.Jul 9 2015, 9:27 AM

Change 222565 abandoned by Addshore:
Add optional validation to ParseValue api

Reason:
Abandon per daniels alternative

https://gerrit.wikimedia.org/r/222565

thiemowmde mentioned this in T104862: [Bug] Date input parses YYYY MM DD as CURDAY CURMONTH YYYY or not at all.Jul 9 2015, 9:35 AM
thiemowmde added a parent task: T104862: [Bug] Date input parses YYYY MM DD as CURDAY CURMONTH YYYY or not at all.
Ricordisamoa subscribed.Jul 25 2015, 2:52 AM
• Jonas mentioned this in T92619: make Wikidata browsertests non-flaky (tracking).Jul 27 2015, 4:44 PM
• Jonas added a parent task: T92619: make Wikidata browsertests non-flaky (tracking).
JanZerebecki moved this task from Review to Doing on the Wikidata-Sprint-2015-06-30 board.Jul 28 2015, 8:43 PM
daniel closed subtask T104876: wbparsevalue should use datatype to identify parser as Resolved.Aug 5 2015, 10:43 AM
daniel closed this task as Resolved.Aug 5 2015, 10:52 AM

patch merged

daniel reopened this task as Open.Aug 5 2015, 10:52 AM

oops, sorry - this one isn't merged yet

gerritbot added a comment.Aug 5 2015, 5:02 PM

Change 223192 merged by jenkins-bot:
Add optional validation to wbparsevalue

https://gerrit.wikimedia.org/r/223192

daniel mentioned this in rEWBA973647dd8bc0: Add optional validation to wbparsevalue.Aug 5 2015, 5:02 PM
Diffusion mentioned this in rMEXT27a35d3c92e8: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 5 2015, 5:02 PM
daniel closed this task as Resolved.Aug 5 2015, 5:46 PM

patch merged

Lydia_Pintscher moved this task from Doing to Done on the Wikidata-Sprint-2015-06-30 board.Aug 7 2015, 5:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits