Page MenuHomePhabricator
Create Task
Maniphest T104377

Links to [[.ar]] etc. inside a transclusion throw an error from ve.ce.MWTransclusionNode:178 as the href makes mw.Title break
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Description VisualEditor will not load completely
Intention: Tried to edit Aruba using ve but will not load completely
Steps to Reproduce: Edit any of the articles at https://en.wikipedia.org/wiki/Special:WhatLinksHere/Template:Infobox_country (majority of the articles)
Results: VisualEditor hangs and will not load completely
Page where the issue occurs Most [but not all] articles that transclude Template:Infobox country
Web browser Firefox 38.0
Operating system Ubunto 14.4 LTS
Skin Vector
Notes: Other articles that transclude Template:Infobox country like Juan de Nova Island will load just fine
I tried it logged in (En Wikipedia and Ilo Wikipedia) and logged out (Ilo Wikipedia, Tl Wikipedia)

Reported at https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#VisualEditor_will_not_load_completely (permalink)

Confirmed on https://en.wikipedia.org/wiki/Jordan?veaction=edit (also using Firefox 38 and in Chromium 37, Ubuntu)

Details

ProjectBranchLines +/-Subject
mediawiki/corewmf/1.26wmf12+16 -2mw.Title: Handle empty this.title
mediawiki/coremaster+16 -2mw.Title: Handle empty this.title
Customize query in gerrit

Related Objects

Event Timeline

Quiddity created this task.Jun 30 2015, 7:32 PM
Quiddity raised the priority of this task from to Needs Triage.
Quiddity updated the task description. (Show Details)
Quiddity added a project: VisualEditor.
Quiddity added a subscriber: Quiddity.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 30 2015, 7:32 PM
Quiddity added a comment.Jul 1 2015, 5:30 AM

Oh, I meant to add webconsole:

titles:[titles];state=state===undefined?true:!!state;var i,pages=this.pages,len=titles.length;for(i=0;i<len;i++){pages[titles[i]]=state;}return true;}};Title.prototype={constructor:Title,getNamespaceId:function(){return this.namespace;},getNamespacePrefix:function(){return this.namespace===NS_MAIN?'':(mw.config.get('wgFormattedNamespaces')[this.namespace].replace(/ /g,'_')+':');},getName:function(){if($.inArray(this.namespace,mw.config.get('wgCaseSensitiveNamespaces'))!==-1){return this.title;}return this.title[0].toUpperCase()+this.title.slice(1);},getNameText:function(){return text(this.getName());},getExtension:function(){return this.ext;},getDotExtension:function(){return this.ext===null?'':'.'+this.ext;},getMain:function(){return this.getName()+this.getDotExtension();},getMainText:function(){return text(this.getMain());},getPrefixedDb:function(){return this.getNamespacePrefix()+this.getMain();},getPrefixedText:function(){return text(this.getPrefixedDb());},getRelativeText:function
Quiddity updated the task description. (Show Details)Jul 1 2015, 5:36 AM
Quiddity set Security to None.
Quiddity updated the task description. (Show Details)
TheDJ added a subscriber: TheDJ.Jul 1 2015, 9:33 AM

undefined is not an object (evaluating 'this.title[0].toUpperCase')

This sounds like a bug in a replacement of ucFirst ????

Jdforrester-WMF renamed this task from VisualEditor will not load completely - TypeError: this.title[0] is undefined - at some articles with {{infobox country}} on enwiki to Links to [[.ar]] etc. inside a transclusion throw an error from ve.ce.MWTransclusionNode:178 as the href makes mw.Title break.Jul 1 2015, 3:28 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Krenair added projects: MediaWiki-General, JavaScript.Jul 1 2015, 3:40 PM
Krenair added a subscriber: Krenair.
gerritbot added a subscriber: gerritbot.Jul 1 2015, 3:43 PM

Change 222132 had a related patch set uploaded (by Alex Monk):
mw.Title: Handle empty this.title

https://gerrit.wikimedia.org/r/222132

gerritbot added a project: Patch-For-Review.Jul 1 2015, 3:43 PM
Krenair claimed this task.Jul 1 2015, 3:51 PM
gerritbot added a comment.Jul 1 2015, 7:24 PM

Change 222132 merged by jenkins-bot:
mw.Title: Handle empty this.title

https://gerrit.wikimedia.org/r/222132

Krenair mentioned this in rMW120ec6bb082a: mw.Title: Handle empty this.title.Jul 1 2015, 7:24 PM
Krenair closed this task as Resolved.Jul 1 2015, 7:30 PM

That should fix this in theory. Please reopen if the patch gets deployed to your wiki but does not actually fix the issue.

Jdforrester-WMF added a subscriber: Jdforrester-WMF.Jul 1 2015, 7:37 PM

Confirmed fixed on http://en.wikipedia.beta.wmflabs.org/wiki/Aruba?veaction=edit

Jdforrester-WMF edited projects, added VisualEditor 2015/16 Q1 blockers; removed Patch-For-Review.Jul 1 2015, 7:37 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Backlog: T0 on the VisualEditor 2015/16 Q1 blockers board.
Jdforrester-WMF moved this task from Backlog: T0 to Done on the VisualEditor 2015/16 Q1 blockers board.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Jul 1 2015, 7:50 PM
Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-07-07_(1.26wmf13).Jul 1 2015, 8:00 PM
gerritbot added a comment.Jul 4 2015, 8:20 AM

Change 222743 had a related patch set uploaded (by Krinkle):
mw.Title: Handle empty this.title

https://gerrit.wikimedia.org/r/222743

gerritbot added a project: Patch-For-Review.Jul 4 2015, 8:20 AM
Krinkle added a subscriber: Krinkle.Jul 4 2015, 8:21 AM

Backporting since this means loading https://en.wikipedia.org/w/index.php?title=Tokelau&veaction=edit causes a fatal crash – due to the link to [[.tk]] – resulting in an incomplete progress bar and no communication to the user.

Maybe we should try/catch a thing or two during initialisation so that not every exception results in this indefinite loading state where the user is clueless.

gerritbot added a comment.Jul 4 2015, 8:30 AM

Change 222743 merged by jenkins-bot:
mw.Title: Handle empty this.title

https://gerrit.wikimedia.org/r/222743

Krinkle mentioned this in rMW2761273cb78c: mw.Title: Handle empty this.title.Jul 4 2015, 8:31 AM
Forrestbot added a project: WMF-deploy-2015-06-30_(1.26wmf12).Jul 4 2015, 9:00 AM
Jdforrester-WMF removed a project: VisualEditor 2015/16 Q1 blockers.Jul 21 2015, 6:29 PM
Jdforrester-WMF removed a project: Patch-For-Review.Sep 1 2015, 10:53 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL