Maniphest T104386

Remove unused global variables in functions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Physikerwelt
	Jun 30 2015, 9:03 PM

Tags

Referenced Files

None

Subscribers

Description

Some function in the MathSearch extension use the global keyword (cf http://php.net/manual/en/language.variables.scope.php section The global keyword) but do not use the variable in the function therafter.
Delete all unused variables defined via the global keyword.

Details

	Subject	Repo	Branch	Lines +/-
	Remove unused global variables in functions	mediawiki/extensions/MathSearch	master	+3 -4

Customize query in gerrit

Related Objects

Mentioned In: rMEXTc86aad5896ce: Updated mediawiki/extensions Project: mediawiki/extensions/MathSearch…
rEMAS8fa5958be37d: Remove unused global variables in functions

Event Timeline

Physikerwelt created this task.Jun 30 2015, 9:03 PM

Physikerwelt assigned this task to Dyiop.

Physikerwelt raised the priority of this task from to Medium.

Physikerwelt updated the task description. (Show Details)

Physikerwelt added a project: MathSearch.

Physikerwelt added subscribers: Physikerwelt, Hcohl.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 30 2015, 9:03 PM

Aklapper added projects: good first task, Technical-Debt.Jun 30 2015, 10:49 PM

Change 222125 had a related patch set uploaded (by Dyiop):
Remove unused global variables in functions

https://gerrit.wikimedia.org/r/222125

gerritbot added a project: Patch-For-Review.Jul 3 2015, 9:17 PM

Change 222125 merged by jenkins-bot:
Remove unused global variables in functions

https://gerrit.wikimedia.org/r/222125

• AkashShah mentioned this in rEMAS8fa5958be37d: Remove unused global variables in functions.Jul 3 2015, 9:23 PM

• AkashShah mentioned this in rMEXTc86aad5896ce: Updated mediawiki/extensions Project: mediawiki/extensions/MathSearch….

Physikerwelt closed this task as Resolved.Jul 4 2015, 6:50 AM

Physikerwelt set Security to None.