Page MenuHomePhabricator

Make sure Firefox 39 doesn't break fix for T70537
Closed, ResolvedPublic1 Estimated Story Points

Description

To work around a browser bug (see T70537: In production, sometimes page scrolling stops working and in the console getting "Error: offset was inside a handlesOwnChildren node" in Firefox), we added .ve-ce-focusableNode * { -moz-user-select: none; }. The browser bug this was working around ( https://bugzilla.mozilla.org/show_bug.cgi?id=1132768 ) is fixed in FF39, but a different browser bug we were exploiting to be able to do this workaround ( https://bugzilla.mozilla.org/show_bug.cgi?id=1097242 ) was also fixed in FF39. Currently FF38 seems to be the latest stable version; when FF39 comes out (or ideally, before then) we should check if the fix for the second bug breaks our workaround for the first bug.

Event Timeline

Catrope raised the priority of this task from to Needs Triage.
Catrope updated the task description. (Show Details)
Catrope subscribed.
dchan set Security to None.

I tried the dev edition of FF40 (available from https://www.mozilla.org/en-US/firefox/developer/) and it does look like something broke:

  1. Click on a table cell; entire table cell is highlighted
  2. Double-click on the cell; cursor appears in the cell
  3. Click elsewhere in the cell

FF38 (expected behavior): selection moves to the place you clicked
FF40 (broken behavior): entire table gets selected

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

@Catrope, I think that table breakage is T103035, which looks resolved to me in Firefox 40 (beta) and 41.0a2 (aurora).