Page MenuHomePhabricator

PHP Notices/ Warnings from DataModel's SnakList
Closed, ResolvedPublic1 Estimated Story Points

Description

Seeing the following after the deploy (happened twice):

Jun 30 23:21:00 mw1017:  #012Notice: Undefined index: P11 in /srv/mediawiki/php-1.26wmf12/extensions/Wikidata/vendor/wikibase/data-model/src/Snak/SnakList.php on line 129
Jun 30 23:21:00 mw1017:  #012Warning: Invalid argument supplied for foreach() in /srv/mediawiki/php-1.26wmf12/extensions/Wikidata/vendor/wikibase/data-model/src/Snak/SnakList.php on line 141

Event Timeline

hoo raised the priority of this task from to Needs Triage.
hoo updated the task description. (Show Details)
hoo added subscribers: hoo, Bene, JeroenDeDauw and 2 others.

All this code is old, from 2013, and untouched since then. Is there more in the log? Who calls SnakList::orderByProperty()? And yes, there is an actual bug in the code that never had a test. I'm going to fix it.

That's the problem with these logs… we don't have any traces or request URLs or anything :( If I had more information, I would have posted it.

Haha, this bug showed up because addshore is in the office now and can be raged to :)

Yup, it just wanted to hide for a year and a half first

demon triaged this task as Medium priority.Jul 9 2015, 4:39 PM