Page MenuHomePhabricator
Create Task
Maniphest T104410

Don't log exception "Not allowed to convert" for normal conditions.
Open, HighPublic
Actions

Description

See

P854 (An Untitled Masterwork)
1<?php
2
3class Something {
4 public function outer() {
5 $inner = function () {
6 $this->somethingSecret();
7 };
8
9 $inner();
10 }
11
12 protected function somethingSecret() {
13 echo "You figured it out\n";
14 }
15}
16
17$s = new Something();
18$s->outer();
,
P855 First Beta run of convertNamespaceToWikitext.php in Catalan Beta
1mattflaschen@deployment-bastion:~$ mwscript extensions/Flow/maintenance/convertNamespaceFromWikitext.php --wiki=cawiki --no-convert-templates 'Discussió arxivada' --archive-pattern '%s/Arxiu %d' 'Project_talk' [2015-06-30 21:31:07] Starting conversion of Viquipèdia_Discussió namespace
2[2015-06-30 21:31:07] Archiving page from Viquipèdia Discussió:Test to Viquipèdia Discussió:Test/Arxiu 1
3[2015-06-30 21:31:09] Importing to Viquipèdia Discussió:Test
4[2015-06-30 21:31:10] Importing header
5[2015-06-30 21:31:11] Imported 1 revisions for header
6[2015-06-30 21:31:11] Imported 1 items, failed 0
7[2015-06-30 21:31:11] Completed import to Viquipèdia Discussió:Test from Viquipèdia Discussió:Test/Arxiu 1
8[2015-06-30 21:31:11] Exception while importing: Viquipèdia Discussió:Arch
9[2015-06-30 21:31:11] exception 'Flow\Exception\FlowException' with message 'Not allowed to convert: Viquipèdia Discussió:Arch' in /mnt/srv/mediawiki-staging/php-master/extensions/Flow/includes/Import/Converter.php:136
10Stack trace:
11#0 /mnt/srv/mediawiki-staging/php-master/extensions/Flow/includes/Import/Converter.php(108): Flow\Import\Converter->convert(Object(Title))
12#1 /mnt/srv/mediawiki-staging/php-master/extensions/Flow/maintenance/convertNamespaceFromWikitext.php(94): Flow\Import\Converter->convertAll(Object(EchoCallbackIterator))
13#2 /mnt/srv/mediawiki-staging/php-master/maintenance/doMaintenance.php(103): ConvertNamespaceFromWikitext->execute()
14#3 /mnt/srv/mediawiki-staging/php-master/extensions/Flow/maintenance/convertNamespaceFromWikitext.php(99): require_once('/mnt/srv/mediaw...')
15#4 /mnt/srv/mediawiki-staging/multiversion/MWScript.php(97): require_once('/mnt/srv/mediaw...')
16#5 {main}
17[2015-06-30 21:31:11] Archiving page from Viquipèdia Discussió:Test2 to Viquipèdia Discussió:Test2/Arxiu 2
18[2015-06-30 21:31:11] Importing to Viquipèdia Discussió:Test2
19[2015-06-30 21:31:12] Importing header
20[2015-06-30 21:31:12] Imported 1 revisions for header
21[2015-06-30 21:31:12] Imported 1 items, failed 0
22[2015-06-30 21:31:12] Completed import to Viquipèdia Discussió:Test2 from Viquipèdia Discussió:Test2/Arxiu 2
23[2015-06-30 21:31:12] Exception while importing: Viquipèdia Discussió:Test2/Arxiu 1
24[2015-06-30 21:31:12] exception 'Flow\Exception\FlowException' with message 'Not allowed to convert: Viquipèdia Discussió:Test2/Arxiu 1' in /mnt/srv/mediawiki-staging/php-master/extensions/Flow/includes/Import/Converter.php:136
25Stack trace:
26#0 /mnt/srv/mediawiki-staging/php-master/extensions/Flow/includes/Import/Converter.php(108): Flow\Import\Converter->convert(Object(Title))
27#1 /mnt/srv/mediawiki-staging/php-master/extensions/Flow/maintenance/convertNamespaceFromWikitext.php(94): Flow\Import\Converter->convertAll(Object(EchoCallbackIterator))
28#2 /mnt/srv/mediawiki-staging/php-master/maintenance/doMaintenance.php(103): ConvertNamespaceFromWikitext->execute()
29#3 /mnt/srv/mediawiki-staging/php-master/extensions/Flow/maintenance/convertNamespaceFromWikitext.php(99): require_once('/mnt/srv/mediaw...')
30#4 /mnt/srv/mediawiki-staging/multiversion/MWScript.php(97): require_once('/mnt/srv/mediaw...')
31#5 {main}
32[2015-06-30 21:31:12] Exception while importing: Viquipèdia Discussió:Test2/Subpage
33[2015-06-30 21:31:12] exception 'Flow\Exception\FlowException' with message 'Not allowed to convert: Viquipèdia Discussió:Test2/Subpage' in /mnt/srv/mediawiki-staging/php-master/extensions/Flow/includes/Import/Converter.php:136
34Stack trace:
35#0 /mnt/srv/mediawiki-staging/php-master/extensions/Flow/includes/Import/Converter.php(108): Flow\Import\Converter->convert(Object(Title))
36#1 /mnt/srv/mediawiki-staging/php-master/extensions/Flow/maintenance/convertNamespaceFromWikitext.php(94): Flow\Import\Converter->convertAll(Object(EchoCallbackIterator))
37#2 /mnt/srv/mediawiki-staging/php-master/maintenance/doMaintenance.php(103): ConvertNamespaceFromWikitext->execute()
38#3 /mnt/srv/mediawiki-staging/php-master/extensions/Flow/maintenance/convertNamespaceFromWikitext.php(99): require_once('/mnt/srv/mediaw...')
39#4 /mnt/srv/mediawiki-staging/multiversion/MWScript.php(97): require_once('/mnt/srv/mediaw...')
40#5 {main}
41[2015-06-30 21:31:12] Exception while importing: Viquipèdia Discussió:Test2/Subpage 2
42[2015-06-30 21:31:12] exception 'Flow\Exception\FlowException' with message 'Not allowed to convert: Viquipèdia Discussió:Test2/Subpage 2' in /mnt/srv/mediawiki-staging/php-master/extensions/Flow/includes/Import/Converter.php:136
43Stack trace:
44#0 /mnt/srv/mediawiki-staging/php-master/extensions/Flow/includes/Import/Converter.php(108): Flow\Import\Converter->convert(Object(Title))
45#1 /mnt/srv/mediawiki-staging/php-master/extensions/Flow/maintenance/convertNamespaceFromWikitext.php(94): Flow\Import\Converter->convertAll(Object(EchoCallbackIterator))
46#2 /mnt/srv/mediawiki-staging/php-master/maintenance/doMaintenance.php(103): ConvertNamespaceFromWikitext->execute()
47#3 /mnt/srv/mediawiki-staging/php-master/extensions/Flow/maintenance/convertNamespaceFromWikitext.php(99): require_once('/mnt/srv/mediaw...')
48#4 /mnt/srv/mediawiki-staging/multiversion/MWScript.php(97): require_once('/mnt/srv/mediaw...')
49#5 {main}
50[2015-06-30 21:31:12] Exception while importing: Viquipèdia Discussió:Test2/Subpage 3
51[2015-06-30 21:31:12] exception 'Flow\Exception\FlowException' with message 'Not allowed to convert: Viquipèdia Discussió:Test2/Subpage 3' in /mnt/srv/mediawiki-staging/php-master/extensions/Flow/includes/Import/Converter.php:136
52Stack trace:
53#0 /mnt/srv/mediawiki-staging/php-master/extensions/Flow/includes/Import/Converter.php(108): Flow\Import\Converter->convert(Object(Title))
54#1 /mnt/srv/mediawiki-staging/php-master/extensions/Flow/maintenance/convertNamespaceFromWikitext.php(94): Flow\Import\Converter->convertAll(Object(EchoCallbackIterator))
55#2 /mnt/srv/mediawiki-staging/php-master/maintenance/doMaintenance.php(103): ConvertNamespaceFromWikitext->execute()
56#3 /mnt/srv/mediawiki-staging/php-master/extensions/Flow/maintenance/convertNamespaceFromWikitext.php(99): require_once('/mnt/srv/mediaw...')
57#4 /mnt/srv/mediawiki-staging/multiversion/MWScript.php(97): require_once('/mnt/srv/mediaw...')
58#5 {main}
, and http://people.wikimedia.org/~mattflaschen/2015_06_30_Catalan_Project_talk.log .

The current conditions that cause this are:

  • Non-wikitext content model
  • Non-existent page
  • Redirects
  • Script-specific reasons (being/not being an LQT page or not meeting subpage requirements)

These may be worth logging prominently (some more so than others), but probably shouldn't be logged as exceptions as currently.

Related Objects

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits