Refactor face detection to be done on-demand
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	• BGerstle-WMF
	Jul 1 2015, 7:18 PM

Project Tags

Referenced Files

None

Subscribers

Description

New image caching work (T95350) has obsoleted the old disk storage, which effectively breaks centering lead images w/ faces. This is because the current implementation relies on a side-effect of saving data to disk which is no longer being triggered (since we're not writing data to the data store).

Acceptance criteria

Images in article "preview" gallery w/ faces are centered
Face "feature" bounds are cached as unit rectangles and keyed on WMF commons filename

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	async detect faces & center w/ content offset	Bgerstle	apps/ios/wikipedia	5.0	+1 K -675

Customize query in gerrit

Related Objects

Mentioned In: T411524: Wikipedia on iOS crops lead image to people's hair (or: What is the Mona Lisa?)
rAPIWfa08df6ad281: async detect faces & center w/ content offset
Mentioned Here: T95350: Standardize image fetch/cache/fallback logic

Event Timeline

• BGerstle-WMF created this task.Jul 1 2015, 7:18 PM

• BGerstle-WMF raised the priority of this task from to Needs Triage.

• BGerstle-WMF updated the task description. (Show Details)

• BGerstle-WMF added a project: Wikipedia-iOS-App.

• BGerstle-WMF moved this task to Needs Triage on the Wikipedia-iOS-App board.

• BGerstle-WMF subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2015, 7:18 PM

• Fjalapeno moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App board.Jul 5 2015, 7:44 PM

• Fjalapeno moved this task from Product Backlog to Engineering Backlog on the Wikipedia-iOS-App board.

• Fjalapeno moved this task from Engineering Backlog to Needs Design on the Wikipedia-iOS-App board.Jul 6 2015, 5:20 PM

• Fjalapeno moved this task from Needs Design to Needs Estimation on the Wikipedia-iOS-App board.

This sounds like a regression. Why recalculate it each time?

MBinder_WMF set Security to None.Jul 6 2015, 8:43 PM

MBinder_WMF edited a custom field.

• Fjalapeno edited projects, added: Wikipedia-iOS-App-Development; removed: Wikipedia-iOS-App.Jul 6 2015, 9:02 PM

@Mhurd I think we discussed this in person already, but just reiterating here:

Use existing architecture to calculate focal offsets on demand (if not stored on the MWKImage already)

• BGerstle-WMF moved this task from Tasks from Product Backlog to Doing on the Wikipedia-iOS-App-Development board.Jul 20 2015, 2:45 PM

• BGerstle-WMF moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Development board.Jul 21 2015, 1:24 PM

• BGerstle-WMF claimed this task.Jul 21 2015, 1:31 PM

• BGerstle-WMF updated the task description. (Show Details)

Change 226083 merged by jenkins-bot:
async detect faces & center w/ content offset

https://gerrit.wikimedia.org/r/226083

• BGerstle-WMF mentioned this in rAPIWfa08df6ad281: async detect faces & center w/ content offset.Jul 21 2015, 11:05 PM

• BGerstle-WMF moved this task from Needs Code Review to 5.0 Beta Staging on the Wikipedia-iOS-App-Development board.Jul 22 2015, 10:59 AM

MBinder_WMF moved this task from 5.0 Beta Staging to Temporary Done (Grooming) on the Wikipedia-iOS-App-Development board.Oct 7 2015, 9:55 PM

MBinder_WMF closed this task as Resolved.Oct 7 2015, 10:07 PM

Krinkle mentioned this in T411524: Wikipedia on iOS crops lead image to people's hair (or: What is the Mona Lisa?).Dec 2 2025, 4:57 PM

Refactor face detection to be done on-demandClosed, ResolvedPublic2 Estimated Story PointsActions