Page MenuHomePhabricator

UploadWizard campaign cache invalidation seems broken
Open, LowPublic

Description

This is how the UW campaign invalidation mechanism works in theory:

  • when the campaign configuration is saved, CampaignHooks::onPageContentSaveComplete parses all the wikitext fields and puts all templates into the templatelink table as if they were used on the Campaign: page itself
  • CampaignHooks::onLinksUpdateComplete monitors changes to the linked templates and calls UploadWizardCampaign::invalidateCache when one of them changes.

This looks sound but doesn't seem to work in practice: Campaign:tos-rs has a missing template and the cache persisted when it was created. (Could be a side effect of T104395 but changing the content type is a proper edit which should have updated the link tables.)

Event Timeline

Tgr created this task.Jul 1 2015, 10:23 PM
Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added a project: UploadWizard.
Tgr added subscribers: Tgr, MarkTraceur, tomasz.
Restricted Application added a project: Multimedia. · View Herald TranscriptJul 1 2015, 10:23 PM
Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald Transcript
Tgr added a comment.Jul 1 2015, 10:24 PM

As a workaround, a dummy edit on the campaign configuration page works (probably a null edit would too).

Restricted Application added a subscriber: Matanya. · View Herald TranscriptJul 1 2015, 10:24 PM
Jdforrester-WMF triaged this task as Low priority.Sep 4 2015, 6:55 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:59 PM
tomasz removed a subscriber: tomasz.Mar 18 2016, 5:27 PM