Page MenuHomePhabricator

[Regression] /favicon.ico broken. Serves empty 200 OK response from HHVM
Closed, ResolvedPublic

Description

I don't know what happened but it's not working.

We rewrite /favicon.ico to /w/favicon.php. Which is a custom MediaWiki entry point that initialises MediaWiki WebStart and streams content from the url configured in $wgFavicon.

This is a public endpoint used browsers (when there is no <link> tag), but also my various of our own websites – inside a <link> tag in fact. E.g. <link rel="shortcut icon" href="//wikimediafoundation.org/favicon.ico">.

I've tried executing the main steps from the script manually from mwscript eval.php --wiki enwiki on tin, but it works fine there.

https://github.com/wikimedia/operations-mediawiki-config/blob/master/w/favicon.php

Event Timeline

Krinkle raised the priority of this task from to High.
Krinkle updated the task description. (Show Details)
Krinkle added a subscriber: Krinkle.

Change 222253 had a related patch set uploaded (by Krinkle):
favicon/touch icon proxy: Fix broken redirect to internal (http)

https://gerrit.wikimedia.org/r/222253

$ curl -I 'https://test.wikipedia.org/favicon.ico'
HTTP/1.1 200 OK
Server: nginx/1.9.2
Date: Thu, 02 Jul 2015 06:50:51 GMT
Content-Length: 0
Connection: keep-alive
X-Powered-By: HHVM/3.6.1
X-Content-Type-Options: nosniff
Cache-control: public
Expires: Fri, 03 Jul 2015 06:50:51 +0000
X-Varnish: 3207115907, 3423721733
Via: 1.1 varnish, 1.1 varnish
Accept-Ranges: bytes
Age: 0

Change 222253 merged by jenkins-bot:
favicon/touch icon proxy: Fix broken redirect to internal (http)

https://gerrit.wikimedia.org/r/222253

Krinkle claimed this task.
Krinkle edited projects, added HTTPS; removed Patch-For-Review, Varnish.
Krinkle set Security to None.
Krinkle edited subscribers, added: BBlack; removed: gerritbot.