Page MenuHomePhabricator
Create Task
Maniphest T104604

Check if links on load are 'known' rather than 'exist' locally
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Open a page that has [[:File:Apple2.svg|Text]] on it. The file name must be an image that exists at Commons but not on the local wiki.
  1. Look at the color of the link.

This should display as an external/blue link instead of a red link.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Check if links are 'known' rather than 'exist' locallymediawiki/extensions/VisualEditormaster+17 -17
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Whatamidoing-WMF created this task.Jul 2 2015, 6:24 PM
• Whatamidoing-WMF raised the priority of this task from to Medium.
• Whatamidoing-WMF updated the task description. (Show Details)
• Whatamidoing-WMF added projects: VisualEditor-MediaWiki-Links, VisualEditor.
• Whatamidoing-WMF added subscribers: • Whatamidoing-WMF, Aklapper.
Restricted Application added a subscriber: Steinsplitter. · View Herald TranscriptJul 2 2015, 6:24 PM
gerritbot subscribed.Jul 3 2015, 1:22 PM

Change 222589 had a related patch set uploaded (by Esanders):
Check if links are 'known' rather than 'exist' locally

https://gerrit.wikimedia.org/r/222589

gerritbot added a project: Patch-For-Review.Jul 3 2015, 1:22 PM
Krenair subscribed.Jul 3 2015, 3:30 PM

Sounds like this is part of T72123

Jdforrester-WMF closed this task as a duplicate of T65355: Direct link to a non-extant local file ([[:File:Foo]]) is red even if there is an extant file in a remote repo.Jul 3 2015, 3:51 PM
Jdforrester-WMF subscribed.

Actually…

Jdforrester-WMF renamed this task from Valid (blue) links to Commons’ images display as red to Check if links are 'known' rather than 'exist' locally.Jul 3 2015, 3:52 PM
Jdforrester-WMF reopened this task as Open.
Jdforrester-WMF set Security to None.
Jdforrester-WMF added a parent task: T65355: Direct link to a non-extant local file ([[:File:Foo]]) is red even if there is an extant file in a remote repo.
Jdforrester-WMF added a parent task: T72123: VisualEditor redlink detection should obey Title::isAlwaysKnown (so that links to Special pages, EducationProgram pages and GlobalUserPages render correctly).
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Jul 3 2015, 5:38 PM
Jdforrester-WMF added a project: VisualEditor 2015/16 Q1 blockers.Jul 3 2015, 5:46 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Backlog: T1 on the VisualEditor 2015/16 Q1 blockers board.Jul 7 2015, 7:12 PM
gerritbot added a comment.Jul 8 2015, 7:29 PM

Change 222589 merged by jenkins-bot:
Check if links are 'known' rather than 'exist' locally

https://gerrit.wikimedia.org/r/222589

Esanders mentioned this in rEVED8971edb48096: Check if links are 'known' rather than 'exist' locally.Jul 8 2015, 7:29 PM
Jdforrester-WMF renamed this task from Check if links are 'known' rather than 'exist' locally to Check if links on load are 'known' rather than 'exist' locally.Jul 8 2015, 7:34 PM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF claimed this task.

Fixed for "existing" links (there when you open the page). Using parent for "newly created" ones.

Jdforrester-WMF moved this task from Backlog: T1 to Done on the VisualEditor 2015/16 Q1 blockers board.Jul 8 2015, 7:38 PM
• Forrestbot added a project: WMF-deploy-2015-07-14_(1.26wmf14).Jul 8 2015, 8:00 PM
Jdforrester-WMF removed a project: VisualEditor 2015/16 Q1 blockers.Jul 21 2015, 6:29 PM
Jdforrester-WMF removed a project: Patch-For-Review.Sep 1 2015, 10:53 PM
Legoktm subscribed.Aug 3 2016, 7:14 AM

I don't think this works - or it has regressed since. Visiting https://www.mediawiki.org/wiki/Extension:TemplateData?veaction=edit I see that the action=visualeditor API call returns links.known as 1, which should mean "treat all non-missing pages as known". But I then immediately see another APi call (presumably from ve.init.mw.LinkCache) checking the existence of every link on the page, and since T72123 is still broken, it turns the links red again.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits