Page MenuHomePhabricator
Create Task
Maniphest T104672

Convert Blueprint to core's HTML templating
Closed, ResolvedPublic
Actions

Description

Blueprint (and OOUIPlayground) use a few server-side HTML templates supported by local vendor/{lightncandy,werdnum/mediawiki-lightncandy-skin,werdnum/simple-lightncandy} libraries. MediaWiki core (since release 1.25) supports mustache HTML templates and includes lightncandy, so we should try to migrate Blueprint to core's implementation.

Details

SubjectRepoBranchLines +/-
Switch to core's server-side HTML templatingmediawiki/skins/Blueprintmaster+38 -508
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 Resolved• SpageT307 Announcing the Developer Hub prototype release
 Resolved• SpageT299 Release the Developer Hub prototype
 Resolved• SpageT306 Featuring the first three APIs in the Developer Hub
 ResolvedoriT334 Document RCStream in the Developer Hub
 DeclinedNoneT302 API sandboxes for the Developer Hub
 ResolvedNoneT300 Select the three APIs featured at the Developer Hub prototype
 DeclinedNoneT88755 Improve MediaWiki API example behavior
 ResolvedAnomieT89229 API Help should generate [try in ApiSandbox] link to Special:ApiSandbox#action=params from getExamples()
 DeclinedNoneT89318 Replace on-wiki API documentation with Special:ApiHelp transclusion
 OpenNoneT89768 Language support in Special:ApiHelp and its transclusion.
 OpenNoneT90528 Generated API Help doesn't indicate the MediaWiki versions that support a module and parameters.
 Resolved• SpageT89680 Template:ApiEx on mw.org should have a link to "[view in ApiSandbox]".
 DeclinedNoneT335 Document the Content API in the Developer Hub
 ResolvedjeropbrendaT359 Document the Wikidata API in the Developer Hub
 OpenNoneT89863 [Task] Merge on-wiki Wikibase/API documentation into Wikibase apihelp strings.
 DeclinedQgilT303 Setup the Developer Hub prototype
 Resolved• SpageT98164 prototype Data and developer hub with Blueprint skin
 ResolvedQgilT101099 Developer Relations Roadmap
 ResolvedQgilT113030 Developer Relations quarterly review Jul-Sep 2015
 ResolvedQgilT101100 Engineering Community quarterly goals for July-September 2015
 Resolved• SpageT101441 Goal: Integrate the new Web APIs hub with mediawiki.org
 Resolved• SpageT305 Developer Hub homepage
 Resolved• SpageT301 Define the look&feel of the Developer Hub
 DeclinedNoneT93062 Define the navigation elements of the Web APIs hub
 DeclinedNoneT317 "Terms of Use" must be prominently featured in the Developer Hub
 Resolved• SpageT92941 Define personas for dev.wikimedia.org
 Resolved• SpageT92945 Reflect in dev.wikimedia.org what Wikimedia offers to developers
 DeclinedNoneT93610 Put WikimediaUI Style Guide on mediawiki.org
 DeclinedNoneT93613 Deploy Blueprint on mediawiki.org as optional and experimental skin
 Resolved• SpageT104672 Convert Blueprint to core's HTML templating
 ResolvedJdlrobsonT97188 Mustache templates in core do not support partials (client side)
 ResolvedNoneT110988 Blueprint assumes personal_urls[0] contains username

Event Timeline

• Spage created this task.Jul 3 2015, 2:18 AM
• Spage raised the priority of this task from to Medium.
• Spage updated the task description. (Show Details)
• Spage added a project: Blueprint.
• Spage subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 3 2015, 2:18 AM
• Spage added a parent task: T93613: Deploy Blueprint on mediawiki.org as optional and experimental skin.Jul 3 2015, 2:37 AM
• Prtksxna awarded a token.Jul 3 2015, 4:26 AM
• Prtksxna subscribed.
• Prtksxna raised the priority of this task from Medium to High.Jul 3 2015, 4:37 AM
• Prtksxna moved this task from Backlog to Next Up on the Blueprint board.Jul 3 2015, 4:40 AM
gerritbot subscribed.Jul 6 2015, 8:46 PM

Change 223165 had a related patch set uploaded (by Spage):
[WIP] switch to core's server-side HTML templating

https://gerrit.wikimedia.org/r/223165

gerritbot added a project: Patch-For-Review.Jul 6 2015, 8:46 PM
• Spage added a subtask: T97188: Mustache templates in core do not support partials (client side).Jul 6 2015, 8:48 PM
• Spage claimed this task.EditedJul 7 2015, 5:21 PM
• Spage added a project: ECT-July-2015.

My Blueprint patch works, but requires a change to core T97188 (merged).

• Spage moved this task from Backlog to Doing on the ECT-July-2015 board.Jul 7 2015, 5:23 PM
• Spage moved this task from Next Up to Needs Review / Feedback on the Blueprint board.Jul 7 2015, 8:52 PM
Qgil changed the task status from Open to Stalled.Aug 8 2015, 12:51 PM
Qgil lowered the priority of this task from High to Medium.
Qgil set Security to None.
Qgil subscribed.
In T104672#1435181, @Spage wrote:

My Blueprint patch works, but requires a change to core T97188 (merged).

I have translated this in "Stalled".

Volker_E subscribed.Sep 1 2015, 5:09 AM

@Spage

150831_WMF_T104627.png (888×1 px, 52 KB)
Screenshot shows, that the account menu link looses its text content at PS7.

Paladox subscribed.Sep 1 2015, 9:38 AM

Hi that is fixed in the patch I upload d that is why I changed the width.

Volker_E added a subtask: T110988: Blueprint assumes personal_urls[0] contains username.Sep 1 2015, 11:54 PM
• Spage mentioned this in T113067: Blueprint hides the first content_navigation namespace tab, not always the right thing to do..Sep 18 2015, 5:44 PM
Volker_E renamed this task from convert Blueprint to core's HTML templating to Convert Blueprint to core's HTML templating.Sep 24 2015, 1:58 AM
• Spage mentioned this in T114136: Adding cache for 'compile on demand' is not the best solution..Oct 1 2015, 2:45 AM
• Spage merged a task: T114136: Adding cache for 'compile on demand' is not the best solution..
• Spage added a subscriber: Pastakhov.
gerritbot added a comment.Oct 15 2015, 12:51 AM

Change 223165 merged by VolkerE:
Switch to core's server-side HTML templating

https://gerrit.wikimedia.org/r/223165

Volker_E closed this task as Resolved.Oct 15 2015, 1:31 AM
Volker_E moved this task from Needs Review / Feedback to Done on the Blueprint board.
Volker_E removed a project: Patch-For-Review.
Volker_E closed subtask T110988: Blueprint assumes personal_urls[0] contains username as Resolved.Oct 15 2015, 1:34 AM
kaldari changed the status of subtask T97188: Mustache templates in core do not support partials (client side) from Open to Stalled.Dec 2 2015, 2:14 AM
Jdlrobson closed subtask T97188: Mustache templates in core do not support partials (client side) as Resolved.Dec 22 2015, 8:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL