Blueprint is doing all the work of building the regular sidebar, then ignoring it.
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	• Prtksxna
	Jul 3 2015, 4:34 AM

Description

In getLeftNav() - Why reinvent the wheel? Replace all this code with a call to skin->addToSidebar($bar, 'blueprint-left-nav'). And you should be doing this in response to buildSidebar(), not in response to execute().

(from https://gerrit.wikimedia.org/r/#/c/205217/ )

Event Timeline

• Prtksxna created this task.Jul 3 2015, 4:34 AM

• Prtksxna raised the priority of this task from to Medium.

• Prtksxna updated the task description. (Show Details)

• Prtksxna added a project: Blueprint.

• Prtksxna added subscribers: • Prtksxna, • Spage.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 3 2015, 4:34 AM

• Prtksxna moved this task from Backlog to Next Up on the Blueprint board.Jul 3 2015, 4:43 AM

Volker_E subscribed.Sep 14 2015, 1:08 AM

@Prtksxna What's the status of this? In order to moving this forward, I'd need more context of the 'MediaWiki' way of doing it.

In T104679#1636036, @Volker_E wrote:

@Prtksxna What's the status of this? In order to moving this forward, I'd need more context of the 'MediaWiki' way of doing it.

I think @Spage was referring to https://www.mediawiki.org/wiki/Manual:Hooks/SkinBuildSidebar and https://doc.wikimedia.org/mediawiki-core/master/php/classSkin.html#a9c48cc7b179fbfef7d2c6a381f00954c. I am not that familiar with the PHP API, @Spage might be able to help.

Volker_E moved this task from Next Up to Backlog on the Blueprint board.Dec 7 2015, 8:01 AM

The skin is no longer maintained

Blueprint is doing all the work of building the regular sidebar, then ignoring it.Closed, DeclinedPublicActions

Description

Event Timeline

Blueprint is doing all the work of building the regular sidebar, then ignoring it.
Closed, DeclinedPublic
Actions