Page MenuHomePhabricator

visualeditor-dialog-media-dimensionseparator contains trailing whitespace
Closed, ResolvedPublic1 Estimated Story Points

Description

https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/i18n/en.json#L81

visualeditor-dialog-media-dimensionseparator contains trailing whitespace. Trailing whitespace is not preserved when editing MediaWiki pages and by extension in translatewiki.net. The trailing whitespace must be removed or worked around html entity.

Event Timeline

Nikerabbit raised the priority of this task from to Needs Triage.
Nikerabbit updated the task description. (Show Details)
Nikerabbit added a project: VisualEditor.
Nikerabbit added a subscriber: Nikerabbit.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 3 2015, 8:06 AM
Elitre added a subscriber: Elitre.Jul 3 2015, 8:49 AM

Change 222569 had a related patch set uploaded (by Esanders):
Use core dimension widget times separator

https://gerrit.wikimedia.org/r/222569

Should we instead make the message "$1 × $2" so that languages which don't want spaces there can remove them? Or just put them in in code all the time/

Jdforrester-WMF triaged this task as Medium priority.Jul 3 2015, 5:37 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from TR0: Interrupt to TR1: Releases on the VisualEditor board.

Your suggestion for having variables is good, if that works for you.

Jdforrester-WMF closed this task as Resolved.Jul 3 2015, 10:18 PM
Jdforrester-WMF claimed this task.

On reflection, it's not worth the duplication.

Change 222569 merged by jenkins-bot:
Use core dimension widget times separator

https://gerrit.wikimedia.org/r/222569