Page MenuHomePhabricator
Create Task
Maniphest T104691

visualeditor-dialog-media-dimensionseparator contains trailing whitespace
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/i18n/en.json#L81

visualeditor-dialog-media-dimensionseparator contains trailing whitespace. Trailing whitespace is not preserved when editing MediaWiki pages and by extension in translatewiki.net. The trailing whitespace must be removed or worked around html entity.

Details

SubjectRepoBranchLines +/-
Use core dimension widget times separatormediawiki/extensions/VisualEditormaster+3 -4
Customize query in gerrit

Related Objects

Event Timeline

Nikerabbit created this task.Jul 3 2015, 8:06 AM
Nikerabbit raised the priority of this task from to Needs Triage.
Nikerabbit updated the task description. (Show Details)
Nikerabbit added a project: VisualEditor.
Nikerabbit subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 3 2015, 8:06 AM
• Elitre subscribed.Jul 3 2015, 8:49 AM
gerritbot subscribed.Jul 3 2015, 12:00 PM

Change 222569 had a related patch set uploaded (by Esanders):
Use core dimension widget times separator

https://gerrit.wikimedia.org/r/222569

gerritbot added a project: Patch-For-Review.Jul 3 2015, 12:00 PM
Jdforrester-WMF subscribed.Jul 3 2015, 5:24 PM

Should we instead make the message "$1 × $2" so that languages which don't want spaces there can remove them? Or just put them in in code all the time/

Jdforrester-WMF triaged this task as Medium priority.Jul 3 2015, 5:37 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from TR0: Interrupt to TR1: Releases on the VisualEditor board.
Nikerabbit added a comment.Jul 3 2015, 6:15 PM

Your suggestion for having variables is good, if that works for you.

Jdforrester-WMF closed this task as Resolved.Jul 3 2015, 10:18 PM
Jdforrester-WMF claimed this task.

On reflection, it's not worth the duplication.

Jdforrester-WMF reassigned this task from Jdforrester-WMF to Esanders.Jul 3 2015, 10:19 PM
Jdforrester-WMF edited projects, added Technical-Debt, VisualEditor 2015/16 Q1 blockers; removed Patch-For-Review.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2015/16 Q1 blockers board.
gerritbot added a comment.Jul 3 2015, 10:20 PM

Change 222569 merged by jenkins-bot:
Use core dimension widget times separator

https://gerrit.wikimedia.org/r/222569

Esanders mentioned this in rEVED84eadef74a31: Use core dimension widget times separator.Jul 3 2015, 10:20 PM
• Forrestbot added a project: WMF-deploy-2015-07-07_(1.26wmf13).Jul 3 2015, 11:00 PM
Jdforrester-WMF removed a project: VisualEditor 2015/16 Q1 blockers.Jul 21 2015, 6:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL