[Stable] Move the last modified bar to the bottom of the page
Closed, ResolvedPublic
Actions

Description

From T101344 (my emphasis):

Because we are pushing max-width work to stable that includes setting a max-width to the background of the last edited bar, it will be simpler to have the location also at the bottom in stable.

Last modified bar in stable appears at the bottom on the page.
Careful with cached pages but not that it is acceptable for cached pages to show the bar at the top whilst the change propagates out.

Details

Related Gerrit Patches:

mediawiki/extensions/MobileFrontend : master

Promote last-modified-bar beta work to stable

Related Objects
Search...

Status	Assigned	Task
Resolved	• rmoen	T101344 [EPIC] Push max-width and last modified work for mobile on desktop to stable
Resolved	• rmoen	T104697 [Stable] Move the last modified bar to the bottom of the page
Resolved	• rmoen	T108204 Regression: Last modified bar code not running in async mode

Event Timeline

phuedx created this task.Jul 3 2015, 11:38 AM

phuedx raised the priority of this task from to Medium.

phuedx updated the task description. (Show Details)

phuedx added projects: Readers-Web-Backlog, MobileFrontend.

phuedx added subscribers: Moushira, bmansurov, phuedx and 4 others.

phuedx moved this task from Incoming to 2016-17 Q2 on the Readers-Web-Backlog board.Jul 3 2015, 4:01 PM

Florian added a subscriber: Florian.Jul 5 2015, 6:42 PM

Nnemo added a subscriber: Nnemo.Jul 25 2015, 4:17 PM

Jdlrobson moved this task from Backlog to Tasks on the MobileFrontend board.Aug 4 2015, 6:35 PM

Jdlrobson mentioned this in T108204: Regression: Last modified bar code not running in async mode.Aug 10 2015, 11:56 PM

Jhernandez raised the priority of this task from Medium to High.Aug 11 2015, 11:05 AM

Jhernandez set Security to None.

Jdlrobson moved this task from 2016-17 Q2 to Epics/Goals on the Readers-Web-Backlog board.Aug 12 2015, 1:43 AM

Let's get to this and make the code more consistent and remove variations.

Last modified bar in stable appears at the bottom on the page.

Careful with cached pages.

Jhernandez closed subtask T108204: Regression: Last modified bar code not running in async mode as Resolved.Aug 14 2015, 10:25 AM

Jdlrobson updated the task description. (Show Details)Aug 17 2015, 4:30 PM

Jdlrobson edited a custom field.

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-54-28-Days-Later board.Aug 17 2015, 4:33 PM

Jdlrobson removed a project: Reading-Web-Sprint-54-28-Days-Later.

Jdlrobson added a project: Reading-Web-Sprint-55-π.Sep 2 2015, 3:58 PM

Jdlrobson edited a custom field.

Jdlrobson moved this task from Needs Analysis to Focus areas on the Reading-Web-Sprint-55-π board.Sep 2 2015, 4:22 PM

• rmoen claimed this task.Sep 3 2015, 10:08 PM

Change 235904 had a related patch set uploaded (by Robmoen):
Promote beta last-modified-bar work to stable

https://gerrit.wikimedia.org/r/235904

gerritbot added a project: Patch-For-Review.Sep 3 2015, 10:11 PM

phuedx moved this task from Focus areas to Code Review on the Reading-Web-Sprint-55-π board.Sep 7 2015, 12:03 PM

phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-55-π board.Sep 7 2015, 2:30 PM

I think the commits (235904 and 236226) need flipping. What do y'all think?

Agreed. Did you make a decision not to use the different branch @rmoen ?

@phuedx could you get this on staging as is so we can start engaging kaity?

@phuedx could you get this on staging as is so we can start engaging kaity?

Done.

I spoke to soon…

Better.

• rmoen moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-55-π board.Sep 8 2015, 10:03 PM

phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-55-π board.Sep 9 2015, 9:15 AM

• rmoen moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-55-π board.Sep 9 2015, 6:32 PM

bmansurov moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-55-π board.Sep 10 2015, 12:58 AM

phuedx mentioned this in T101344: [EPIC] Push max-width and last modified work for mobile on desktop to stable.Sep 10 2015, 1:03 PM

• rmoen moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-55-π board.Sep 10 2015, 5:03 PM

The only issue with your patches we noted during the design review was the footer styles have not been pushed to beta. Once fixed we can get this merged ! (yay!)

• rmoen moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-55-π board.Sep 11 2015, 7:16 PM

Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-55-π board.Sep 11 2015, 11:37 PM

Change 235904 merged by jenkins-bot:
Promote last-modified-bar beta work to stable

https://gerrit.wikimedia.org/r/235904

• rmoen mentioned this in rMEXT25d5dd2902df: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 11 2015, 11:46 PM

• rmoen mentioned this in rEMFR22a5a7736ab6: Promote last-modified-bar beta work to stable.

ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 12 2015, 12:00 AM

T112341 is the only thing stopping me signing this off

T112341 has been merged.

Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-55-π board.Sep 15 2015, 5:41 PM

Jdlrobson closed this task as Resolved.Sep 16 2015, 5:03 PM