Page MenuHomePhabricator

WikiLove should not silently suppress database errors
Closed, ResolvedPublic

Description

		try{
			$dbw->insert( 'wikilove_log', $values, __METHOD__ );
		} catch( DBQueryError $dbqe ) {
			$this->setWarning( 'Action was not logged' );
		}

This was hiding the fact that the wikilove_log table doesn't exist on all wikis.

Event Timeline

Legoktm created this task.Jul 3 2015, 11:21 PM
Legoktm raised the priority of this task from to High.
Legoktm updated the task description. (Show Details)
Legoktm added projects: WikiLove, Technical-Debt.
Legoktm added a subscriber: Legoktm.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJul 3 2015, 11:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 223590 had a related patch set uploaded (by Legoktm):
API: Log suppressed DBQueryErrors

https://gerrit.wikimedia.org/r/223590

Change 223590 merged by jenkins-bot:
API: Stop suppressing DBQueryErrors

https://gerrit.wikimedia.org/r/223590

Legoktm closed this task as Resolved.Jul 8 2015, 6:52 PM
Legoktm claimed this task.