Page MenuHomePhabricator

[mmv.lightboxinterface] Warning: 'webkitMovementX' is deprecated. Please use 'movementX' instead.
Closed, ResolvedPublic

Description

This non-standard event property has been deprecated. One should either try the standard property first and keep the fallback, or even ignore the deprecated variant entirely if the fallback without can be considered graceful degradation as result of progressive enhancement.

Depends on how visible the impact is and which version of which browsers support it. It seems to WebKit-only in the current implementation, which means the feature may be broken right now in Firefox (which supports Event.movementX as of Firefox 41). – Or perhaps this check is for a Chrome-specific bug of that feature rather than the feature itself?

https://github.com/wikimedia/mediawiki-extensions-MultimediaViewer/blob/82c087750/resources/mmv/mmv.lightboxinterface.js#L418-L424

Event Timeline

Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle subscribed.

Or perhaps this check is for a Chrome-specific bug of that feature rather than the feature itself?

Yes, see https://gerrit.wikimedia.org/r/#/c/173915/. Chrome triggered a mousemove when the DOM node with the mouse in it was replaced, even if the user never touched the mouse.

Probably would work just as well with movementX though.

Change 223517 had a related patch set uploaded (by Gergő Tisza):
Replace webkitMovementX with movementX

https://gerrit.wikimedia.org/r/223517

Change 223517 merged by jenkins-bot:
Replace webkitMovementX with movementX

https://gerrit.wikimedia.org/r/223517

Tgr claimed this task.
demon triaged this task as Medium priority.Jul 9 2015, 4:39 PM