Echo email icons are hardcoded HTTP
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Jul 6 2015, 10:06 AM

Description

		// Use http for image path, there is no need for https
		return wfExpandUrl( $iconUrl, PROTO_HTTP );

Should use PROTO_CANONICAL instead.

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use PROTO_CANONICAL for icon links in emails	mediawiki/extensions/Echo	master	+1 -2

Mentioned In: T55479: Notification emails should embed icons as data URIs
rECHOb12efddf3031: Use PROTO_CANONICAL for icon links in emails
rMEXT976c05f8751c: Updated mediawiki/extensions Project: mediawiki/extensions/Echo…

Legoktm claimed this task.

Legoktm raised the priority of this task from to High.

Legoktm updated the task description. (Show Details)

Legoktm subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 223006 had a related patch set uploaded (by Legoktm):
Use PROTO_CANONICAL for icon links in emails

Change 223006 merged by jenkins-bot:
Use PROTO_CANONICAL for icon links in emails

Legoktm closed this task as Resolved.Jul 6 2015, 6:13 PM