Page MenuHomePhabricator

[Task] wbparsevalue should support StringValues, instead of relying on UnknownValue
Closed, ResolvedPublic

Description

The wbparsevalue API module currently does not support the parsing of strings into StringValue objects. Instead, it uses the "null" parser to create UnknownValue objects. The UI has to work around this with special case code. For consistency and sanity, wbparsevalue should support parsing string values.

Event Timeline

daniel raised the priority of this task from to High.
daniel updated the task description. (Show Details)
daniel added subscribers: Jc3s5h, Lydia_Pintscher, daniel and 5 others.

Change 230097 merged by jenkins-bot:
Use StringParser in wbparsevalue API

https://gerrit.wikimedia.org/r/230097

daniel claimed this task.

the backend part is done

Change 236545 had a related patch set uploaded (by Daniel Kinzler):
Use a proper StringParser instead of NullParser for StringValues.

https://gerrit.wikimedia.org/r/236545

Reopen because of regression. Looks like I broke this when introducing the new mechanism for registering ValueParsers. Fix on gerrit: https://gerrit.wikimedia.org/r/236545

Change 236545 merged by jenkins-bot:
Use a proper StringParser instead of NullParser for StringValues.

https://gerrit.wikimedia.org/r/236545

Lydia_Pintscher renamed this task from wbparsevalue should support StringValues, instead of relying on UnknownValue to [Task] wbparsevalue should support StringValues, instead of relying on UnknownValue.Sep 10 2015, 10:26 AM