Page MenuHomePhabricator

setPageTitle('') hides both h1 and page actions
Closed, ResolvedPublic


If I do $out->setPageTitle('') where $out is OutputPage, <h1> and page-actions both disappear.
Expected: only <h1> should disappear.
This is probably because at
no check is being made for page-actions, and 'prebody' text only contains title text.

Event Timeline

Sumit raised the priority of this task from to Needs Triage.
Sumit updated the task description. (Show Details)
Sumit added a project: Readers-Web-Backlog.
Sumit moved this task to Incoming on the Readers-Web-Backlog board.
Sumit added a subscriber: Sumit.

Change 223090 had a related patch set uploaded (by Sumit):
Add pageactions check while rendering pre-content

Florian assigned this task to Sumit.
Florian added a subscriber: Florian.

Change 223090 merged by jenkins-bot:
Add pageactions check while rendering pre-content