Page MenuHomePhabricator

setPageTitle('') hides both h1 and page actions
Closed, ResolvedPublic

Description

If I do $out->setPageTitle('') where $out is OutputPage, <h1> and page-actions both disappear.
Expected: only <h1> should disappear.
This is probably because at https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend.git/c27de038bacdfd26f96ca20ae7b3c3d14f3f24ec/includes%2Fskins%2FMinervaTemplate.php#L282
no check is being made for page-actions, and 'prebody' text only contains title text.

Event Timeline

Sumit created this task.Jul 6 2015, 7:10 PM
Sumit raised the priority of this task from to Needs Triage.
Sumit updated the task description. (Show Details)
Sumit added a project: Readers-Web-Backlog.
Sumit moved this task to Incoming on the Readers-Web-Backlog board.
Sumit added a subscriber: Sumit.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 6 2015, 7:10 PM

Change 223090 had a related patch set uploaded (by Sumit):
Add pageactions check while rendering pre-content

https://gerrit.wikimedia.org/r/223090

Florian closed this task as Resolved.Jul 6 2015, 7:34 PM
Florian assigned this task to Sumit.
Florian added a subscriber: Florian.

Change 223090 merged by jenkins-bot:
Add pageactions check while rendering pre-content

https://gerrit.wikimedia.org/r/223090