Page MenuHomePhabricator
Create Task
Maniphest T104898

Replace wgVisualEditorNamespaces with a 2D array of namespace => enabled state
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Right now wgVisualEditorNamespaces is a 1D list of namespaces in which VE is enabled. Instead, make this a 2D list of namespace => enabled states with a different name (e.g. wgVisualEditorAvailableNamespaces) so that we can configure namespace enablement better.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix part of the VE NS config issueoperations/mediawiki-configmaster+1 -1
Revert "Revert "Replace wgVisualEditorNamespaces with an associative array""mediawiki/extensions/VisualEditormaster+26 -19
Replace wgVisualEditorNamespaces with an associative arraymediawiki/extensions/VisualEditormaster+23 -19
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Jul 6 2015, 7:15 PM
Jdforrester-WMF assigned this task to Krenair.
Jdforrester-WMF raised the priority of this task from to Needs Triage.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: VisualEditor, VisualEditor-MediaWiki.
Jdforrester-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 6 2015, 7:15 PM
Krenair added a subscriber: Legoktm.Jul 9 2015, 9:33 PM

Per option 3 in @Legoktm's comment in https://gerrit.wikimedia.org/r/#/c/223080/
This would also solve our double-listing of the User namespace in some wikis' preferences

gerritbot subscribed.Jul 9 2015, 9:52 PM

Change 223967 had a related patch set uploaded (by Alex Monk):
Replace wgVisualEditorNamespaces with an associative array

https://gerrit.wikimedia.org/r/223967

gerritbot added a project: Patch-For-Review.Jul 9 2015, 9:52 PM
Jdforrester-WMF triaged this task as Medium priority.Jul 21 2015, 6:44 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.Jul 22 2015, 1:06 AM
Jdforrester-WMF closed this task as Resolved.Jul 23 2015, 11:57 PM
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Jul 23 2015, 11:59 PM

Change 223967 merged by jenkins-bot:
Replace wgVisualEditorNamespaces with an associative array

https://gerrit.wikimedia.org/r/223967

Jdforrester-WMF mentioned this in rEVED647a5597bb4a: Replace wgVisualEditorNamespaces with an associative array.Jul 24 2015, 12:00 AM
• Forrestbot added a project: WMF-deploy-2015-07-28_(1.26wmf16).Jul 24 2015, 12:00 AM
Legoktm reopened this task as Open.Aug 2 2015, 8:52 PM

Reverted in rEVED7ca1afbbd2f0: Revert "Replace wgVisualEditorNamespaces with an associative array".

Legoktm added a subtask: T107646: Merging anything using integer keys in extension registration is broken.Aug 2 2015, 8:53 PM
Legoktm closed subtask T107646: Merging anything using integer keys in extension registration is broken as Resolved.
gerritbot added a comment.Aug 2 2015, 9:31 PM

Change 228198 had a related patch set uploaded (by Alex Monk):
Fix part of the VE NS config issue

https://gerrit.wikimedia.org/r/228198

gerritbot added a project: Patch-For-Review.Aug 2 2015, 9:31 PM

Change 228746 had a related patch set uploaded (by Alex Monk):
Revert "Revert "Replace wgVisualEditorNamespaces with an associative array""

https://gerrit.wikimedia.org/r/228746

gerritbot added a comment.Aug 2 2015, 11:50 PM

Change 228746 merged by jenkins-bot:
Revert "Revert "Replace wgVisualEditorNamespaces with an associative array""

https://gerrit.wikimedia.org/r/228746

Krenair mentioned this in rEVEDea34d938c889: Revert "Revert "Replace wgVisualEditorNamespaces with an associative array"".Aug 2 2015, 11:50 PM
gerritbot added a comment.Aug 2 2015, 11:59 PM

Change 228198 merged by jenkins-bot:
Fix part of the VE NS config issue

https://gerrit.wikimedia.org/r/228198

Krenair mentioned this in rOMWC52adc2f4dd3f: Fix part of the VE NS config issue.Aug 2 2015, 11:59 PM
• Forrestbot added a project: WMF-deploy-2015-08-04_(1.26wmf17).Aug 3 2015, 12:00 AM
Krenair closed this task as Resolved.Aug 3 2015, 12:04 AM
Jdforrester-WMF removed a project: Patch-For-Review.Sep 1 2015, 10:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits