Page MenuHomePhabricator

On labs phabricator references security extension even though it isn't present
Closed, ResolvedPublic

Description

Puppet tries to start phd which returns:

[2015-07-06 19:28:23] EXCEPTION: (PhutilBootloaderException) Include of '/srv/phab/libext/security/src/__phutil_library_init__.php' failed! at [<phut
il>/src/moduleutils/PhutilBootloader.php:209]   
arcanist(head=29839e8c72c569171069272ac824e025883cb634, ref.master=565a96e0ee54), phabricator(head=daf269e48ba07523fbfb281cd551fb94a3bd7f07, ref.mast
er=855f752814eb, custom=4), phutil(head=ea6830cc8019f512e0f3eba4045fb5bdad4c2ced, ref.master=103dc7e39093), sprint(head=master, ref.master=4912ecf41e
f1)
  #0 PhutilBootloader::loadLibrary(string) called at [<phutil>/src/moduleutils/core.php:12]
  #1 phutil_load_library(string) called at [<phabricator>/src/infrastructure/env/PhabricatorEnv.php:194]
  #2 PhabricatorEnv::buildConfigurationSourceStack() called at [<phabricator>/src/infrastructure/env/PhabricatorEnv.php:87]
  #3 PhabricatorEnv::initializeCommonEnvironment() called at [<phabricator>/src/infrastructure/env/PhabricatorEnv.php:68]
  #4 PhabricatorEnv::initializeScriptEnvironment() called at [<phabricator>/scripts/__init_script__.php:21]
  #5 init_phabricator_script() called at [<phabricator>/scripts/__init_script__.php:24]
  #6 require_once(string) called at [<phabricator>/scripts/setup/manage_config.php:5]

Related Objects

Event Timeline

Negative24 claimed this task.
Negative24 raised the priority of this task from to Low.
Negative24 updated the task description. (Show Details)
Negative24 added a subscriber: Negative24.

I don't quite understand why the git repo isn't getting cloned.

Possibly related:

1Error: Could not set 'link' on ensure: No such file or directory - /srv/phab/phabricator/src/extensions at 12:/etc/puppet/modules/phabricator/manifes
2ts/extension.pp
3Error: Could not set 'link' on ensure: No such file or directory - /srv/phab/phabricator/src/extensions at 12:/etc/puppet/modules/phabricator/manifes
4ts/extension.pp
5Wrapped exception:
6No such file or directory - /srv/phab/phabricator/src/extensions
7Error: /Stage[main]/Phabricator/Phabricator::Extension[PhabricatorMediaWikiAuthProvider.php]/File[/srv/phab/phabricator/src/extensions/PhabricatorMed
8iaWikiAuthProvider.php]/ensure: change from absent to link failed: Could not set 'link' on ensure: No such file or directory - /srv/phab/phabricator/
9src/extensions at 12:/etc/puppet/modules/phabricator/manifests/extension.pp
10Notice: /Stage[main]/Phabricator/Git::Install[phabricator/phabricator]/Exec[phabricator/phabricator_confirm_tag_version]/returns: executed successful
11ly
12Info: /Stage[main]/Phabricator/Git::Install[phabricator/phabricator]/Exec[phabricator/phabricator_confirm_tag_version]: Scheduling refresh of Exec[ph
13abricator/phabricator_alert_for_out_of_sync]
14Error: Could not set 'link' on ensure: No such file or directory - /srv/phab/phabricator/src/extensions at 12:/etc/puppet/modules/phabricator/manifes
15ts/extension.pp
16Error: Could not set 'link' on ensure: No such file or directory - /srv/phab/phabricator/src/extensions at 12:/etc/puppet/modules/phabricator/manifes
17ts/extension.pp
18Wrapped exception:
19No such file or directory - /srv/phab/phabricator/src/extensions
20Error: /Stage[main]/Phabricator/Phabricator::Extension[PhutilMediaWikiAuthAdapter.php]/File[/srv/phab/phabricator/src/extensions/PhutilMediaWikiAuthA
21dapter.php]/ensure: change from absent to link failed: Could not set 'link' on ensure: No such file or directory - /srv/phab/phabricator/src/extensio
22ns at 12:/etc/puppet/modules/phabricator/manifests/extension.pp

Only got these errors on a newly created instance. From the looks of it, it should only be a few lines added. I'll look at it tomorrow.

Change 226031 had a related patch set uploaded (by 20after4):
Ensure that phabricator/src/extensions exists

https://gerrit.wikimedia.org/r/226031

Change 226031 merged by Rush:
Ensure that phabricator/src/extensions exists

https://gerrit.wikimedia.org/r/226031

Change 226097 had a related patch set uploaded (by 20after4):
Ensure that phabricator/src/extensions exists

https://gerrit.wikimedia.org/r/226097

Change 226097 merged by Rush:
Ensure that phabricator/src/extensions exists

https://gerrit.wikimedia.org/r/226097

Negative24 added a subscriber: 20after4.

Those two commits ensure the directory is created but doesn't install the security extension for labs. Either security_tag needs to be set in role::phabricator::labs so that this happens or the security extension be removed from [[ https://github.com/wikimedia/operations-puppet/blob/production/manifests/role/phabricator.pp#L203 | libraries ]] so that it isn't referenced in the Phabricator configs.

It all depends on whether we want the security extension in labs or not (@20after4: have a preference?)

I think we want the security extension in labs. At least until we deprecate it's use. I'm in the process of developing a new deployment process for phabricator, but it'll probably be a few more weeks before that's ready.

Change 248646 had a related patch set uploaded (by Negative24):
phabricator: Set security ext tag for labs

https://gerrit.wikimedia.org/r/248646

Change 248646 merged by Rush:
phabricator: Set security ext tag for labs

https://gerrit.wikimedia.org/r/248646