Page MenuHomePhabricator
Create Task
Maniphest T104923

OOUI\TextInputWidget should support 'autocomplete' parameter (to turn it off)
Closed, ResolvedPublic
Actions

Description

E.g. for TitleInputWidget or maybe other implementations, TextInputWidget should support the use of the 'autocomplete' (e.g. to turn it off when needed) attribute.

TitleInputWidget looks actually like:

Unbenannt.PNG (149×783 px, 2 KB)

Details

SubjectRepoBranchLines +/-
TextInputWidget: Allow setting the HTML autocomplete attribute oojs/uimaster+14 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Florian created this task.Jul 6 2015, 10:19 PM
Florian raised the priority of this task from to Needs Triage.
Florian updated the task description. (Show Details)
Florian added a project: OOjs core.
Florian added subscribers: Florian, Legoktm, matmarex.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 6 2015, 10:19 PM
Florian claimed this task.Jul 6 2015, 10:21 PM
matmarex added a comment.Jul 6 2015, 10:35 PM

Wait, what about LookupElement? You can mix it into stuff (like a TextInputWidget subclass) and get autocompletion.

Florian removed Florian as the assignee of this task.Jul 6 2015, 10:39 PM

Hmm? The task is to disable the browser autocomplete function :)

matmarex added a comment.Jul 6 2015, 10:41 PM

Oooh. Okay, I misread. :)

matmarex renamed this task from OOUI\TextInputWidget should support autocomplete to OOUI\TextInputWidget should support 'autocomplete' parameter (to turn it off).Jul 6 2015, 10:41 PM
matmarex updated the task description. (Show Details)
matmarex set Security to None.
gerritbot subscribed.Jul 6 2015, 11:02 PM

Change 223197 had a related patch set uploaded (by Florianschmidtwelzow):
Allow to set the autocomplete attribute to TextInputWidget

https://gerrit.wikimedia.org/r/223197

gerritbot added a project: Patch-For-Review.Jul 6 2015, 11:02 PM
gerritbot added a comment.Jul 6 2015, 11:05 PM

Change 223199 had a related patch set uploaded (by Florianschmidtwelzow):
Disable browser provided autocomplete function in TitleInputWidget

https://gerrit.wikimedia.org/r/223199

Florian claimed this task.Jul 6 2015, 11:05 PM
gerritbot added a comment.Jul 7 2015, 3:39 PM

Change 223197 merged by jenkins-bot:
TextInputWidget: Allow setting the HTML autocomplete attribute

https://gerrit.wikimedia.org/r/223197

Jdforrester-WMF mentioned this in rGOJUcd64c1ad3deb: TextInputWidget: Allow setting the HTML autocomplete attribute.Jul 7 2015, 3:39 PM
Jdforrester-WMF closed this task as Resolved.Jul 7 2015, 6:09 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.11.8); removed OOjs-UI-next-release.Jul 9 2015, 4:05 PM
matmarex added a parent task: T105459: Search suggestions by browser and by MediaWiki overlap on Special:Search.Jul 10 2015, 1:55 PM
Krinkle edited projects, added OOUI; removed OOUI (OOjs-UI-0.11.8), OOjs core.Aug 14 2020, 1:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL