Page MenuHomePhabricator
Create Task
Maniphest T104951

DynamicSidebar should not use $wgUser in an extension function - breaks SemanticMediaWiki
Closed, ResolvedPublic
Actions

Description

When I install MediaWiki 1.25.1 (from the download-tarball), add SemanticMediaWiki 2.2.1 using composer and then install DynamicSidebar (git master snapshot) I end up with a somewhat broken SemanticMediaWiki.

Best seen by going to "Special:Properties": The list of the 20 internal properties of SMW then looks like this

List of properties

  1. NO_VALID_VALUE (0)
  2. NO_VALID_VALUE (0)
  3. NO_VALID_VALUE of type Date (0 uses)
  4. NO_VALID_VALUE (0)
  5. NO_VALID_VALUE (0)

...

but should look like this:

List of properties

  1. Allows value (0)
  2. Corresponds to (0)
  3. Creation date of type Date (0 uses)
  4. Display units (0)
  5. Equivalent URI (0)

...

I tried to find out what's going on and saw that the namespaces that are added by SMW ("Property", "Type", "Concept" and their "..._talk") seem to disappear, when DynamicSidebar ist loaded...
Any ideas?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use SidebarBeforeOutput hook & stop disabling sidebar cachemediawiki/extensions/DynamicSidebarREL1_25+3 -24
Use SidebarBeforeOutput hook & stop disabling sidebar cachemediawiki/extensions/DynamicSidebarmaster+3 -24
Customize query in gerrit

Related Objects

Event Timeline

HermannSchwaerzler created this task.Jul 7 2015, 6:57 AM
HermannSchwaerzler raised the priority of this task from to Needs Triage.
HermannSchwaerzler updated the task description. (Show Details)
HermannSchwaerzler added a project: MediaWiki-extensions-DynamicSidebar.
HermannSchwaerzler subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2015, 6:57 AM
HermannSchwaerzler updated the task description. (Show Details)Jul 7 2015, 8:17 AM
HermannSchwaerzler set Security to None.
Aklapper renamed this task from MW 1.25.1 + SMW 2.2.1 + DynamicSidebar => SMW is borked to SMW + DynamicSidebar: "Special:Properties" does not show valid values.Jul 7 2015, 11:17 AM
Aklapper updated the task description. (Show Details)
mwjames mentioned this in T104954: ExtensionRegistry / wgExtensionFunctions not treated as array?.Jul 22 2015, 12:05 AM
HermannSchwaerzler added a comment.Jul 24 2015, 9:22 AM

This seems to be a problem/bug in MediaWiki-core. See https://phabricator.wikimedia.org/T104954

HermannSchwaerzler edited projects, added MediaWiki-General; removed MediaWiki-extensions-DynamicSidebar.Jul 24 2015, 9:24 AM
Legoktm renamed this task from SMW + DynamicSidebar: "Special:Properties" does not show valid values to DynamicSidebar should not use $wgUser in an extension function - breaks SemanticMediaWiki.Jul 31 2015, 4:39 AM
Legoktm claimed this task.
Legoktm triaged this task as High priority.
Legoktm edited projects, added MediaWiki-extensions-DynamicSidebar; removed MediaWiki-General.
gerritbot subscribed.Jul 31 2015, 4:46 AM

Change 228201 had a related patch set uploaded (by Legoktm):
Use SidebarBeforeOutput hook & stop disabling sidebar cache

https://gerrit.wikimedia.org/r/228201

gerritbot added a project: Patch-For-Review.Jul 31 2015, 4:46 AM
gerritbot added a comment.Jul 31 2015, 6:22 AM

Change 228201 merged by jenkins-bot:
Use SidebarBeforeOutput hook & stop disabling sidebar cache

https://gerrit.wikimedia.org/r/228201

Legoktm mentioned this in rMEXTc6c97f7083ab: Updated mediawiki/extensions Project: mediawiki/extensions/DynamicSidebar….Jul 31 2015, 6:22 AM
Legoktm mentioned this in rEDSB09d2585e92fc: Use SidebarBeforeOutput hook & stop disabling sidebar cache.
• Forrestbot added a project: WMF-deploy-2015-08-04_(1.26wmf17).Jul 31 2015, 7:00 AM
gerritbot added a comment.Jul 31 2015, 7:51 AM

Change 228209 had a related patch set uploaded (by Legoktm):
Use SidebarBeforeOutput hook & stop disabling sidebar cache

https://gerrit.wikimedia.org/r/228209

gerritbot added a comment.Jul 31 2015, 7:56 AM

Change 228209 merged by jenkins-bot:
Use SidebarBeforeOutput hook & stop disabling sidebar cache

https://gerrit.wikimedia.org/r/228209

Legoktm mentioned this in rEDSB0ecd70319d60: Use SidebarBeforeOutput hook & stop disabling sidebar cache.Jul 31 2015, 7:57 AM
Legoktm closed this task as Resolved.Jul 31 2015, 8:03 AM

Fixed in master and I backported it to the REL1_25 branch.

HermannSchwaerzler added a comment.Jul 31 2015, 9:17 AM

Thanks, Legoktm.
Re-pulling DynamicSidebar with your fix solved the problem for me!

Legoktm merged a task: T88955: DynamicSidebar should not use $wgUser inside $wgExtensionFunctions.Nov 19 2015, 5:49 PM
Legoktm added subscribers: Liuxinyu970226, Legoktm.
Liuxinyu970226 unsubscribed.Nov 21 2015, 11:43 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits