Page MenuHomePhabricator

DynamicSidebar should not use $wgUser in an extension function - breaks SemanticMediaWiki
Closed, ResolvedPublic

Description

When I install MediaWiki 1.25.1 (from the download-tarball), add SemanticMediaWiki 2.2.1 using composer and then install DynamicSidebar (git master snapshot) I end up with a somewhat broken SemanticMediaWiki.

Best seen by going to "Special:Properties": The list of the 20 internal properties of SMW then looks like this

List of properties

  1. NO_VALID_VALUE (0)
  2. NO_VALID_VALUE (0)
  3. NO_VALID_VALUE of type Date (0 uses)
  4. NO_VALID_VALUE (0)
  5. NO_VALID_VALUE (0)

...

but should look like this:

List of properties

  1. Allows value (0)
  2. Corresponds to (0)
  3. Creation date of type Date (0 uses)
  4. Display units (0)
  5. Equivalent URI (0)

...

I tried to find out what's going on and saw that the namespaces that are added by SMW ("Property", "Type", "Concept" and their "..._talk") seem to disappear, when DynamicSidebar ist loaded...
Any ideas?

Event Timeline

HermannSchwaerzler raised the priority of this task from to Needs Triage.
HermannSchwaerzler updated the task description. (Show Details)
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2015, 6:57 AM
HermannSchwaerzler set Security to None.
Aklapper renamed this task from MW 1.25.1 + SMW 2.2.1 + DynamicSidebar => SMW is borked to SMW + DynamicSidebar: "Special:Properties" does not show valid values.Jul 7 2015, 11:17 AM
Aklapper updated the task description. (Show Details)

This seems to be a problem/bug in MediaWiki-core. See https://phabricator.wikimedia.org/T104954

Legoktm renamed this task from SMW + DynamicSidebar: "Special:Properties" does not show valid values to DynamicSidebar should not use $wgUser in an extension function - breaks SemanticMediaWiki.Jul 31 2015, 4:39 AM
Legoktm claimed this task.
Legoktm triaged this task as High priority.

Change 228201 had a related patch set uploaded (by Legoktm):
Use SidebarBeforeOutput hook & stop disabling sidebar cache

https://gerrit.wikimedia.org/r/228201

Change 228201 merged by jenkins-bot:
Use SidebarBeforeOutput hook & stop disabling sidebar cache

https://gerrit.wikimedia.org/r/228201

Change 228209 had a related patch set uploaded (by Legoktm):
Use SidebarBeforeOutput hook & stop disabling sidebar cache

https://gerrit.wikimedia.org/r/228209

Change 228209 merged by jenkins-bot:
Use SidebarBeforeOutput hook & stop disabling sidebar cache

https://gerrit.wikimedia.org/r/228209

Legoktm closed this task as Resolved.Jul 31 2015, 8:03 AM

Fixed in master and I backported it to the REL1_25 branch.

Thanks, Legoktm.
Re-pulling DynamicSidebar with your fix solved the problem for me!