Page MenuHomePhabricator

Page does not automatically refresh after 'Hide'/'Unhide' comment action - "Failed to getInstanceByElement: no $container.length"
Closed, ResolvedPublic

Description

  1. On en.wikipedia.beta.wmflabs.org Flow page, hide a comment - the comment will be hidden and UI will display "This comment was hidden by user (history)" .
  1. Click on the (history) link from above -
e.g.
<a href="/w/index.php?title=Topic:Sjauynsdv6leiauj&amp;action=history">history</a>
  1. On the View history page click on 'unhide'
<a class="mw-ui-anchor mw-ui-quiet" href="http://en.wikipedia.beta.wmflabs.org/w/index.php?
title=Topic:Sknr8kvlswqin33f&amp;action=moderate-post&amp;topic_moderationState=unhide&amp;topic_postId=sknr8kwcb04je99n" title="Unhide" 
data-flow-interactive-handler="moderationDialog" data-flow-template="flow_moderate_post.partial" data-role="unhide">unhide</a>
  1. The following errors are displayed in the Console and the page is not refreshed.
"[FLOW] " "Failed to getInstanceByElement: no $container.length" Arguments { 0: Object, 2 more… } load.php:175:850
FlowComponent.prototype.debug() load.php:175....

and

"[FLOW] " "Error in component handler:" "makeContentInteractive" TypeError: component.emitWithReturn is not a function...
  1. Clicking again, on 'unhide' - will display 'Unhide' popup. When clicking 'Unhide' there will display "Insufficient permissions to execute this action."

In fact, Unhide action has been performed in step #3 - the page did no refreshed upon clicking 'unhide'. Clicking 'delete' and 'suppress' will refresh the history page automatically to reflect the actions.

The same issue is for 'hide' action.

Event Timeline

Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added a subscriber: Etonkovidova.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2015, 10:13 PM
Etonkovidova renamed this task from Page does not automatically refreshed after 'Hide'/'Unhide' comment action - "Failed to getInstanceByElement: no $container.length" to Page does not automatically refresh after 'Hide'/'Unhide' comment action - "Failed to getInstanceByElement: no $container.length".Jul 7 2015, 10:14 PM
Etonkovidova set Security to None.

Change 223771 had a related patch set uploaded (by Matthias Mullie):
Use boardHistory component for topic history

https://gerrit.wikimedia.org/r/223771

Change 223771 merged by jenkins-bot:
Use boardHistory component for topic history

https://gerrit.wikimedia.org/r/223771

Etonkovidova closed this task as Resolved.Jul 10 2015, 9:36 PM