Page MenuHomePhabricator
Create Task
Maniphest T105236

extension.json schema does not support custom parameters/classes for "ResourceModules"
Closed, ResolvedPublic
Actions

Description

Custom RL modules can define their own parameters, so validating against the ResourceLoaderFileModule ones isn't going to work. We need to:

  • Remove the "additionalProperties": false,
  • Not validate parameters if a 'class' property is set.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+165 -108registration: Support custom classes in "ResourceModules" schema
Customize query in gerrit

Event Timeline

Legoktm created this task.Jul 8 2015, 9:36 PM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added projects: MediaWiki-Configuration, MediaWiki-ResourceLoader.
Legoktm added subscribers: Legoktm, Krinkle.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2015, 9:36 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.Jul 8 2015, 9:37 PM
Krinkle removed a subscriber: Krinkle.Jul 8 2015, 9:38 PM
Krinkle added a subscriber: Krinkle.
Legoktm added a comment.Aug 2 2015, 9:43 PM

According to https://stackoverflow.com/questions/9029524/json-schema-specify-field-is-required-based-on-value-of-another-field we might be able to do this using the v3 or v4 schemas..

gerritbot added a subscriber: gerritbot.Aug 2 2015, 11:42 PM

Change 228753 had a related patch set uploaded (by Legoktm):
registration: Support custom classes in "ResourceModules" schema

https://gerrit.wikimedia.org/r/228753

gerritbot added a project: Patch-For-Review.Aug 2 2015, 11:43 PM
Legoktm claimed this task.Aug 2 2015, 11:43 PM
Krinkle triaged this task as Medium priority.Aug 5 2015, 1:03 AM
Krinkle set Security to None.
Krinkle moved this task from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.
gerritbot added a comment.Oct 27 2015, 4:56 AM

Change 228753 merged by jenkins-bot:
registration: Support custom classes in "ResourceModules" schema

https://gerrit.wikimedia.org/r/228753

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)), MW-1.27-release-notes.Oct 27 2015, 5:00 AM
Legoktm closed this task as Resolved.Jan 2 2016, 12:14 AM
Krinkle moved this task from Accepted Enhancement to External on the MediaWiki-ResourceLoader board.Aug 19 2016, 6:34 AM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL