Page MenuHomePhabricator
Create Task
Maniphest T105271

this.fragments doesn't seem to be used in mw.languageToolAction
Closed, ResolvedPublic
Actions

Description

this.fragments doesn't seem to be used in mw.languageToolAction. If it's not used, it should be removed.

Related Objects

Event Timeline

Amire80 created this task.Jul 9 2015, 6:37 AM
Amire80 assigned this task to Ankita-ks.
Amire80 raised the priority of this task from to High.
Amire80 updated the task description. (Show Details)
Amire80 added a project: VisualEditor-LanguageTool.
Amire80 added subscribers: Aklapper, Amire80.
Amire80 moved this task from Backlog to Hygiene on the VisualEditor-LanguageTool board.Jul 9 2015, 6:46 AM
Amire80 lowered the priority of this task from High to Low.Jul 9 2015, 8:34 AM
Amire80 set Security to None.
Aklapper added a project: good first task.Jul 9 2015, 12:42 PM

(Please feel enouraged to tag good first task tasks as such.)

Jdforrester-WMF added a project: VisualEditor.Jun 1 2016, 3:48 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJun 1 2016, 3:48 PM
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Jun 3 2016, 10:16 PM
Aklapper added a comment.Oct 3 2017, 4:46 PM

@Ankita-ks: This issue has been assigned to you a while ago.
Could you please share a status update? Are you still working (or still plan to work) on this issue? Is there anything that others could help with? If you do not plan to work on this issue anymore, please remove yourself as assignee (via Add Action... → Assign / Claim in the dropdown menu) so others could work on it. Thanks a lot!

Restricted Application added a subscriber: jeblad. · View Herald TranscriptOct 3 2017, 4:46 PM
matmarex closed this task as Resolved.Oct 23 2018, 12:38 AM
matmarex subscribed.

ext.LanguageToolAction.js was removed in rELNT76aa7ee8f31b: Bug Fix : Highlights were removed after the first check and did not reappear. I can only find this.fragments in ext.LanguageToolDialog.js now, where it certainly appears to be used.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 23 2018, 12:38 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL