Page MenuHomePhabricator

CirrusSearch suggestions are not always logged
Closed, ResolvedPublic

Description

We think that we aren't logging as many suggestions as are actually occurring. Lets make sure we aren't dropping them and, if we are, we should fix that.

Event Timeline

Manybubbles claimed this task.
Manybubbles raised the priority of this task from to Needs Triage.
Manybubbles updated the task description. (Show Details)
Manybubbles subscribed.

So I heard that the whether or not a suggestion was returned is not always logged but I'm not sure this is true. Here is what I found:

manybubbles@fluorine:/a/mw-log$ head -n 1000000 CirrusSearchRequests.log  | grep 'DEBUG: full_text' | grep 'and suggested ' | wc -l
40530
manybubbles@fluorine:/a/mw-log$ head -n 1000000 CirrusSearchRequests.log  | grep 'DEBUG: full_text' | grep -v 'and suggested ' | wc -l
198542

So that means we only return suggestions on about 17% of full text searches. That isn't mind boggling.

Manybubbles set Security to None.
Manybubbles added a subscriber: EBernhardson.

Another neat point of reference: ~20% of queries that return no results get a suggestion.

manybubbles@fluorine:/a/mw-log$ head -n 1000000 CirrusSearchRequests.log  | grep 'DEBUG: full_text' | grep 'Found 0 total results and' | wc -l
66027
manybubbles@fluorine:/a/mw-log$ head -n 1000000 CirrusSearchRequests.log  | grep 'DEBUG: full_text' | grep 'Found 0 total results and' | grep 'and suggested ' | wc -l
13069

I'm going to claim this is resolved. The number look pretty believable. If we decide they aren't later we can fix them.