Page MenuHomePhabricator

Remove back-compat "OO.ui" prefix assumption in infusion code for OOUI 0.14.0+
Closed, ResolvedPublic

Description

In https://gerrit.wikimedia.org/r/#/c/223507/, we add back-compat code for cached PHP output that does not include the "OO.ui" prefix due to being created with an older version of the library. This code should be removed after the next major release (or something).

Event Timeline

Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added a project: OOUI.
Legoktm subscribed.
Jdforrester-WMF renamed this task from Remove back-compat "OO.ui" prefix assumption in infusion code after next OOUI major release to Remove back-compat "OO.ui" prefix assumption in infusion code for OOUI 0.14.0+.Aug 10 2015, 10:56 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set Security to None.
Jdforrester-WMF subscribed.

Did we explicitly deprecate them then?

Define "explicit"? What's OOUI's deprecation policy?

Define "explicit"? What's OOUI's deprecation policy?

  • No unannounced breaking changes.
  • Breaking changes cause a version bump (semver, so X.Y -> X+1.0, or 0.X.Y -> 0.X+1.0 for pre-1.0 versions).
  • Announce deprecations in the change for that release, and remind in the announcement e-mail for the next major version).
  • Breaking changes should be preceded by a deprecation notice for at least two cycles (so deprecate in 0.X.A, mention again in 0.X+1.0, actually remove and make a breaking change in 0.X+2.0).
  • Provide a backwards-compatible shim wherever possible for two cycles.

Change 367693 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[oojs/ui@master] Remove back-compat "OO.ui" prefix assumption in infusion code

https://gerrit.wikimedia.org/r/367693

Change 367693 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] Remove back-compat "OO.ui" prefix assumption in infusion code

https://gerrit.wikimedia.org/r/367693

Volker_E assigned this task to Prtksxna.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.