Page MenuHomePhabricator
Create Task
Maniphest T105425

convertLqtPageOnLocalWiki.php should handle empty/invalid title
Closed, ResolvedPublic
Actions

Description

Currently it throws:

[2015-07-09 23:22:14] Starting LQT conversion of page

Catchable fatal error: Argument 1 passed to Flow\Import\Converter::convert() must be an instance of Title, null given, called in /mnt/srv/mediawiki-staging/php-master/extensions/Flow/includes/Import/Converter.php on line 108 and defined in /mnt/srv/mediawiki-staging/php-master/extensions/Flow/includes/Import/Converter.php on line 123

Hit this when accidentally had a blank line at the end of the file.

Related Objects

Event Timeline

• Mattflaschen-WMF created this task.Jul 9 2015, 11:27 PM
• Mattflaschen-WMF raised the priority of this task from to Needs Triage.
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 9 2015, 11:27 PM
• Mattflaschen-WMF added a project: StructuredDiscussions.Jul 9 2015, 11:27 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJul 9 2015, 11:27 PM
• Mattflaschen-WMF added a comment.Jul 9 2015, 11:28 PM

With my while read page command-line wrapper (see T92303: Convert LQT pages on MediaWiki.org to Flow (tracking)).

• DannyH added a parent task: T92303: Convert LQT pages on MediaWiki.org to Flow (tracking).Aug 4 2015, 11:04 PM
• DannyH moved this task from Untriaged to LQT tickets (temporary) on the Collaboration-Team-Triage board.Aug 4 2015, 11:07 PM
• DannyH removed a parent task: T92303: Convert LQT pages on MediaWiki.org to Flow (tracking).Aug 4 2015, 11:45 PM
Catrope triaged this task as Medium priority.Aug 5 2015, 11:16 PM
Catrope set Security to None.
• DannyH moved this task from LQT tickets (temporary) to Freezer on the Collaboration-Team-Triage board.Aug 20 2015, 11:57 PM
Krinkle closed this task as Resolved.Oct 27 2018, 6:53 PM
Krinkle subscribed.

It seems the latest version of this script does not accept an input file with line breaks. Instead, it accepts a single title via the srcpage option. It can still break if invoked once by hand with an invalid parameter, which could be given better validation/error message, but it no longer aborts half-way due to an extra empty line in a file or some such.

Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 27 2018, 6:53 PM
Krinkle edited projects, added Wikimedia-production-error; removed Collaboration-Team-Triage.Oct 27 2018, 6:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL