Page MenuHomePhabricator
Create Task
Maniphest T105551

Duplicate icons: 'remove' and 'trash'
Closed, ResolvedPublic
Actions

Description

We have duplicate icons: 'remove' remove.png (24×24 px, 172 B) and 'trash' trash.png (24×24 px, 193 B). We should probably merge them, keeping the first (original) for Apex theme and the second for MediaWiki theme.

Details

SubjectRepoBranchLines +/-
[DEPRECATING CHANGE] De-duplicate 'trash' and 'remove' iconsoojs/uimaster+9 -20
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Jul 10 2015, 9:17 PM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added a project: OOUI.
matmarex subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 10 2015, 9:17 PM
Ricordisamoa subscribed.Jul 11 2015, 8:11 AM
matmarex added a project: good first task.Jul 16 2015, 9:12 PM
matmarex added a parent task: T55733: Use the same icons to represent the same things (tracking).Sep 1 2015, 1:38 PM
gerritbot subscribed.Nov 21 2015, 3:05 AM

Change 254630 had a related patch set uploaded (by Jforrester):
[DEPRECATING CHANGE] De-duplicate 'trash' and 'remove' icons

https://gerrit.wikimedia.org/r/254630

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 21 2015, 3:05 AM
gerritbot added a project: Patch-For-Review.Nov 21 2015, 3:05 AM
Jdforrester-WMF claimed this task.Nov 21 2015, 3:06 AM
Jdforrester-WMF set Security to None.
Jdforrester-WMF triaged this task as Low priority.Nov 21 2015, 3:24 AM
gerritbot added a comment.Nov 24 2015, 9:45 PM

Change 254630 merged by jenkins-bot:
[DEPRECATING CHANGE] De-duplicate 'trash' and 'remove' icons

https://gerrit.wikimedia.org/r/254630

Jdforrester-WMF closed this task as Resolved.Nov 24 2015, 10:58 PM
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), OOUI (OOjs-UI-0.14.0); removed OOjs-UI-next-release.Nov 25 2015, 2:31 AM
Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Jan 7 2016, 4:05 AM
Esanders subscribed.Mar 25 2016, 6:41 PM

'trash' is an American English-only word. while 'remove' is still an alias I think we should change this to deprecate in the other direction ('remove' as the canonical term).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL