Page MenuHomePhabricator

Wikibugs should ignore changes to the security field
Open, Needs TriagePublic

Description

This is still happening. I think there was a task for it already that got solved (T647). However, due to T87135 this still happens quite frequently.

E.g. T104164 was created June 29th. And July 12th a change was made to the CC-list (the first change to that task) . That change resulted in an IRC notification. Presumably because the CC-filter didn't work as the event also also contained a "set Security to None." component.

Event Timeline

Krinkle created this task.Jul 12 2015, 11:56 AM
Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added a project: Wikibugs.
Krinkle added a subscriber: Krinkle.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2015, 11:56 AM
2015-07-12 11:51:18,623 - wikibugs.wb2-phab - DEBUG - get_transaction_info(104164,OrderedDict([('PHID-XACT-TASK-wb3glbgrmvzsfpf', 'PHID-XACT-TASK-wb3glbgrmvzsfpf'), ('PHID-XACT-TASK-2bgwvcst6bllpur', 'PHID-XACT-TASK-2bgwvcst6bllpur')])) = {"core:customfield": {"new": "default", "old": null}, "core:subscribers": {"new": ["PHID-USER-sai77mtxmpqnm6pycyvz", "PHID-USER-hgn5uw2jafgjgfvxibhh", "PHID-USER-doeppszazlm3r7xah4il"], "old": ["PHID-USER-sai77mtxmpqnm6pycyvz", "PHID-USER-hgn5uw2jafgjgfvxibhh"]}}

So, we need to ignore changes under the name 'core:customfield'? @mmodell, is there anything else besides the security thing using that name?

Legoktm updated the task description. (Show Details)Jul 12 2015, 7:03 PM
Legoktm set Security to None.

the phab API (manifest.gettasktransactions) exposes only the following data:

{
  "taskID": "104164",
  "transactionPHID": "PHID-XACT-TASK-2bgwvcst6bllpur",
  "transactionType": "core:customfield",
  "oldValue": null,
  "newValue": "default",
  "comments": null,
  "authorPHID": "PHID-USER-sai77mtxmpqnm6pycyvz",
  "dateCreated": "1436701875"
},

so I don't see how to determine which customfield it is...

Legoktm renamed this task from Wikibugs should not send IRC notifications if the only change was CC to Wikibugs should ignore changes to the security field.Jul 12 2015, 7:19 PM

@Legoktm: The other custom fields are story points and bugzilla id. Since those are numeric, you can assume if newValue and oldValue are either null or a string then it is the security field (I know this is a bad assumption, since it might change in the future, but it would work for now)

Or to be more specific, just ignore cases where it's exactly oldValue: null and newValue: "default" since that should cover the security field setting.

Change 233665 had a related patch set uploaded (by Legoktm):
Use CodeEditor for HTML templates on Meta-Wiki

https://gerrit.wikimedia.org/r/233665

Change 233665 had a related patch set uploaded (by Legoktm):

Ignore, wrong bug.

mmodell removed a subscriber: mmodell.Aug 27 2015, 1:18 AM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 15 2015, 4:10 AM
jayvdb added a subscriber: jayvdb.Nov 15 2015, 4:10 AM