502 doesn't sound like an appropriate status code. Wayback machine doesn't seem to like it, either. 404 would be better.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Don't die on a non-existent user page | analytics/quarry/web | master | +5 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Invalid | Feature | None | T16720 robots.txt (tracking) | ||
| Resolved | Krenair | T105662 quarry.wmflabs.org/robots.txt gives 502 |
Event Timeline
Comment Actions
According to Yuvi, this is uwsgi swallowing these exceptions:
File "/srv/venv/lib/python2.7/site-packages/flask/app.py", line 1836, in __call__
return self.wsgi_app(environ, start_response)
File "/srv/venv/lib/python2.7/site-packages/flask/app.py", line 1820, in wsgi_app
response = self.make_response(self.handle_exception(e))
File "/srv/venv/lib/python2.7/site-packages/flask/app.py", line 1403, in handle_exception
reraise(exc_type, exc_value, tb)
File "/srv/venv/lib/python2.7/site-packages/flask/app.py", line 1817, in wsgi_app
response = self.full_dispatch_request()
File "/srv/venv/lib/python2.7/site-packages/flask/app.py", line 1477, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/srv/venv/lib/python2.7/site-packages/flask/app.py", line 1381, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/srv/venv/lib/python2.7/site-packages/flask/app.py", line 1475, in full_dispatch_request
rv = self.dispatch_request()
File "/srv/venv/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request
Display the sourcecode for this frameOpen an interactive python shell in this framereturn self.view_functions[rule.endpoint](**req.view_args)
File "/vagrant/quarry/web/user.py", line 39, in user_page
user = g.conn.session.query(User).filter(func.lower(User.username) == user_name).one()
File "/srv/venv/lib/python2.7/site-packages/sqlalchemy/orm/query.py", line 2375, in one
raise orm_exc.NoResultFound("No row was found for one()")
NoResultFound: No row was found for one()Comment Actions
Change 266021 had a related patch set uploaded (by Alex Monk):
Don't die on a non-existent user page