Page MenuHomePhabricator

Update dashboards to handle new adjustments to 'did you mean' feature
Closed, ResolvedPublic


The did you mean feature will start internally re-running suggested queries. To the existing CirrusSearchRequests log this will still look like there is a no result query requested via web though. makes a small addition to the logs, an executor id. This uniquely identifies the execution context of a request. Multiple requests with the same executor id and run within a short timespan of each other should be treated as if only the last query returned results.

Event Timeline

EBernhardson raised the priority of this task from to Needs Triage.
EBernhardson updated the task description. (Show Details)
EBernhardson added a subscriber: EBernhardson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2015, 8:51 PM

If you point me in the right direction I might be able to make these adjustments. I see but that seems to be just the functions, and not the glue that gets run against the actual CirrusSearchRequests files.

Who is 'you'? Is Ironholds supposed to be CC'd here? What projects are supposed to be on this ticket?

An example of the logs to be processed:

These are just the queries run as part of the browser tests, but might be a good enough sample to test against.

I ended up finding the code that does this, I'm pretty sure it is

I've got a patch worked up that should do the trick, but havn't fully tested yet.

I consider that it should work this way:


  • User runs query A and gets 0 results and a search suggestion B. This is logged as a zero result query.
  • User runs query B and gets results. This is not logged as a zero results query.


  • User runs query A. Backend sees 0 results and search suggestion B, runs search suggestion B, and gives that to the user. This is not logged as a zero results query.

I figure this is probably the way you've implemented it, but I wanted to make sure the requirements are clear.

@EBernhardson is the log change now live?

@Ironholds not yet, someone needs to +2 the following patches:

Add executor id to CirrusSearchRequests log

Start internally forwarding/rewriting zero result queries with suggestions

Is it done without those being merged and deployed? ;p

Yes, because the ticket says 'Update dashboards to handle' and the dashboards now appropriately handle the data. Getting the data into the dashboard is a tasked blocked by this one.

Now deployed!

Ironholds closed this task as Resolved.Jul 31 2015, 5:43 PM