Page MenuHomePhabricator

Add Less to list of SyntaxHighlight_GeSHi.lexers.php
Closed, ResolvedPublic

Description

Hi please add Less to SyntaxHighlight_GeSHi.lexers.php. See for example https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS#LESS where CSS is currently set due to missing support.

Related Objects

Event Timeline

Paladox raised the priority of this task from to Needs Triage.
Paladox updated the task description. (Show Details)
Paladox added a project: SyntaxHighlight.
Paladox added subscribers: Paladox, ori, Legoktm, Krinkle.

Seems reasonable. We will need to review the aliases each time a new Pygments version is released.

Volker_E renamed this task from Add less to list of SyntaxHighlight_GeSHi.lexers.php to Add LESS to list of SyntaxHighlight_GeSHi.lexers.php .Aug 4 2015, 1:46 PM
Volker_E awarded a token.
Volker_E updated the task description. (Show Details)
Volker_E set Security to None.
Volker_E subscribed.
Volker_E renamed this task from Add LESS to list of SyntaxHighlight_GeSHi.lexers.php to Add Less to list of SyntaxHighlight_GeSHi.lexers.php .Aug 4 2015, 1:53 PM
Volker_E updated the task description. (Show Details)

Change 258694 had a related patch set uploaded (by John Vandenberg):
Map 'less' to 'css'

https://gerrit.wikimedia.org/r/258694

Change 258694 abandoned by TheDJ:
Map 'less' to 'css'

Reason:
Now done in core pygments.

https://gerrit.wikimedia.org/r/258694

TheDJ added a project: Verified.

This mapping is now provided by upstream.

@TheDJ Where do you find the wished outcome in upstream? Links from above both are still showing "open".

Actually, I should be a bit more nuanced. Less is now an alias for css in upstream. The merged patch was not rolled back, even though this was implied in a comment of the pull request. It's not really ideal however.

There is a demo here: http://pygments.org/demo/3762938/

@TheDJ Besides smaller glitches, like inappropriate border-radius or ignoring inline comments, that's a big step forward. Good to see that happen!

We might want to fork this ticket for full support of less, as described in the ticket https://bitbucket.org/birkenfeld/pygments-main/issues/780/add-a-less-lexer ?

I actually made a demo as well, forgot to past the link before: http://pygments.org/demo/3763103/