Page MenuHomePhabricator

Port ErfgoedBot to Pywikibot-core
Closed, ResolvedPublic

Description

ErfgoedBot is still using the old compat branch, which will be breaking soon. We need to port ErfgoedBot to use the new core branch. This is useful for Wiki loves Monuments.

Event Timeline

JeanFred claimed this task.
JeanFred raised the priority of this task from to Medium.
JeanFred updated the task description. (Show Details)
JeanFred set Security to None.

Thank you Jean-Fred for committing to this task, it will help us move forward.

I just had a chat with @Jdforrester-WMF who told me that @jayvdb fixed compat for the API continuation problem. So the port to core is a bit less urgent, but given that compat deprecation is very real (T101214) this is still to be done.

I just had a chat with @Jdforrester-WMF who told me that @jayvdb fixed compat for the API continuation problem.

@Xqt takes the blame for fixing compat; I only reviewed and +2'd the patch.

So the port to core is a bit less urgent, but given that compat deprecation is very real (T101214) this is still to be done.

The decommissioning of compat is supposed to be occurring at Wikimania, so it is very real, and porting scripts to core is very urgent.
On the pywikibot IRC channel are people who can help with the port.

Is the ErfgoedBot code is in a public repo?

So the port to core is a bit less urgent, but given that compat deprecation is very real (T101214) this is still to be done.

The decommissioning of compat is supposed to be occurring at Wikimania, so it is very real, and porting scripts to core is very urgent.

Thanks for the clarification John!

Is the ErfgoedBot code is in a public repo?

It is in Gerrit: https://git.wikimedia.org/summary/labs%2Ftools%2Fheritage.git

What is the status of this task, now that Wikimania 2015 is over? As this task is in the "Backlog" column of the #Wikimania-Hackathon-2015 project's workboard: Did this task take place and was successfully finished? If yes: Please provide an update (and if the task is not completely finished yet, please move the project to the "Work continues after Mexico City" column on the #Wikimania-Hackathon-2015 workboard). If no: Please edit this task by removing the #Wikimania-Hackathon-2015 project from this task. Thanks for your help and keeping this task updated!

Once this is up-and-running, I'd be happy to talk about syncing with Wikidata.

Made some good progress over the past week and week-end.

First step was to backport all the local changes of tools.heritage back in Gerrit.

Second step was to converted the scripts. I worked (helped by the very nice compat2core) on all the ones run as part of the daily bin/update_monuments.sh:

  • update_database.py
  • populate_image_table.py
  • database_statistics.py
  • unused_monument_images.py
  • missing_commonscat_links.py
  • categorize_images.py

All of those have been tested individually and should basically work (but not thoroughly so it’s completely possible that an outdated, failing syntax hides somewhere in a underused conditional). Look for ErfgoedBot edits on Commons and some Wikipedias for some test edits.

(Also implemented some Wikidata-related goodie in T110003 :-).

I would almost say it’s ready to go. Will launch back the daily re-processing a bit later.

With the help of @Multichill, and with quite some more work to prevent crashes (see for example rTHERe8579ea6a2c0, rTHER8b33b39fa03e, rTHERc506d5f2fc2d, rTHER4a0d848e20d0), the bot is now running. Even if it fails on one country, it will keep going on the other ones. This will take quite a while.

The database will then be updated (assuming the mysql operation does not crash because the database decides to become unavailable).

I think that Spanish Wikipedia hasn't been updated. You can see data from pt, gl and ca, but not es https://tools.wmflabs.org/wlm-maps/#7/41.034/-4.872

I’m closing this as Resolved − the ErfgoedBot is now run pywikibot-core. Follow-up on T110497 and T110498.