Page MenuHomePhabricator
Create Task
Maniphest T105878

Browser tests failing for Gather
Closed, ResolvedPublic
Actions

Description

The change in T101295 broke how the main menu gets interacted with.

This causes the Gather tests around main menu functionality to now fail with
unable to locate element, using {:id=>"mw-mf-main-menu-button", :tag_name=>"a"} (Watir::Exception::UnknownObjectException)

This is unfortunate, especially given it is my understanding the main menu work is a temporary experiment.
Fix should be generic enough to work for main menu in stable and beta

Task is only resolved when the @skip tags are removed from those tests.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Gathermaster+0 -2Revert "Avoid spamming mailing list by skipping"
mediawiki/extensions/MobileFrontendmaster+1 -6Hygiene: Adjust styling of main menu so browser tests do not fail
mediawiki/extensions/Gathermaster+4 -2QA: Fix menu browser test
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jul 15 2015, 12:57 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Reading-Web-Sprint-51-YOLO, Gather.
Jdlrobson moved this task to To Do on the Reading-Web-Sprint-51-YOLO board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2015, 12:57 PM
Jdlrobson updated the task description. (Show Details)Jul 15 2015, 12:58 PM
Jdlrobson set Security to None.
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-51-YOLO board.Jul 15 2015, 1:30 PM
gerritbot added a subscriber: gerritbot.Jul 15 2015, 2:27 PM

Change 224796 had a related patch set uploaded (by Jdlrobson):
QA: Fix menu browser test

https://gerrit.wikimedia.org/r/224796

gerritbot added a project: Patch-For-Review.Jul 15 2015, 2:27 PM
gerritbot added a comment.Jul 15 2015, 9:25 PM

Change 224796 merged by jenkins-bot:
QA: Fix menu browser test

https://gerrit.wikimedia.org/r/224796

• Konfused-Kitten mentioned this in rMEXT0f0e95b52b71: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Jul 15 2015, 9:25 PM
• rmoen mentioned this in rEGAT8cfd0b4a2704: QA: Fix menu browser test.Jul 15 2015, 9:25 PM
Forrestbot added a project: WMF-deploy-2015-07-21_(1.26wmf15).Jul 15 2015, 10:00 PM
gerritbot added a comment.Jul 16 2015, 3:33 AM

Change 225001 had a related patch set uploaded (by Jdlrobson):
Hygiene: Adjust styling of main menu so browser tests do not fail

https://gerrit.wikimedia.org/r/225001

Jdlrobson added a subscriber: • rmoen.Jul 16 2015, 3:34 AM

It seems the new header bar, creates an absolutely positioned header-title element that covers the left icon so it cannot receive clicks. Since the css doesn't really make sense I've proposed to remove it in https://gerrit.wikimedia.org/r/225001 would be great @rmoen if you could merge this since everyone else is at Wikimania so we can stop the mailing list spam and get Gather's builds green again. Thanks dude!

Jdlrobson claimed this task.Jul 16 2015, 3:34 AM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-51-YOLO board.
Jdlrobson added a comment.Jul 19 2015, 4:32 AM

I added @skip tags. Adding removal of these to task description.

Jdlrobson updated the task description. (Show Details)Jul 19 2015, 4:32 AM
Diffusion mentioned this in rMEXTc809d9c5007c: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Jul 19 2015, 4:34 AM
• Konfused-Kitten mentioned this in rEGAT36c1826f3a6e: Avoid spamming mailing list by skipping.Jul 19 2015, 4:34 AM
gerritbot added a comment.Jul 19 2015, 12:17 PM

Change 225001 merged by jenkins-bot:
Hygiene: Adjust styling of main menu so browser tests do not fail

https://gerrit.wikimedia.org/r/225001

• Konfused-Kitten mentioned this in rMEXT4920a7544798: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jul 19 2015, 12:17 PM
Florian mentioned this in rEMFR8b51ee1dbf4c: Hygiene: Adjust styling of main menu so browser tests do not fail.Jul 19 2015, 12:18 PM
• KLans_WMF edited projects, added Reading-Web-Sprint-52-Zoolander; removed Reading-Web-Sprint-51-YOLO.Jul 20 2015, 4:07 PM
• KLans_WMF moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-52-Zoolander board.
Jdlrobson closed this task as Resolved.Jul 20 2015, 6:19 PM
gerritbot added a comment.Jul 20 2015, 6:20 PM

Change 225931 had a related patch set uploaded (by Jdlrobson):
Revert "Avoid spamming mailing list by skipping"

https://gerrit.wikimedia.org/r/225931

Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-52-Zoolander board.Jul 20 2015, 6:21 PM
Jdlrobson moved this task from Ready for Signoff to Code Review on the Reading-Web-Sprint-52-Zoolander board.Jul 21 2015, 8:54 PM

Someone needs to merge the above.. ^

Jdlrobson reopened this task as Open.Jul 21 2015, 8:55 PM
bmansurov moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-52-Zoolander board.Jul 21 2015, 9:14 PM
gerritbot added a comment.Jul 21 2015, 11:02 PM

Change 225931 merged by jenkins-bot:
Revert "Avoid spamming mailing list by skipping"

https://gerrit.wikimedia.org/r/225931

• Konfused-Kitten mentioned this in rEGAT0e78c618f84d: Revert "Avoid spamming mailing list by skipping".Jul 21 2015, 11:02 PM
Diffusion mentioned this in rMEXT3a149241c942: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Jul 21 2015, 11:03 PM
Forrestbot added a project: WMF-deploy-2015-07-28_(1.26wmf16).Jul 22 2015, 12:00 AM
Jdlrobson moved this task from Needs triage to Must haves on the Gather board.Jul 22 2015, 5:22 PM
Jhernandez added a subscriber: Jhernandez.Jul 29 2015, 10:53 AM

Seems to be back to good.

https://integration.wikimedia.org/ci/job/browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/

Dat damn header...

Jhernandez closed this task as Resolved.Jul 29 2015, 10:54 AM
Jhernandez moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-52-Zoolander board.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL