Page MenuHomePhabricator

Starting a new translation from a red link is not opening the right article
Closed, InvalidPublic

Description

As reported here, when clicking on a link you marked as missing, the link card allows to start a new translation but it is actually opening the current article instead of the one the red link represents.

Event Timeline

Pginer-WMF raised the priority of this task from to Needs Triage.
Pginer-WMF updated the task description. (Show Details)
Pginer-WMF added a project: ContentTranslation.
Pginer-WMF added a subscriber: Pginer-WMF.

Change 224853 had a related patch set uploaded (by Santhosh):
Fix: Redlink in link card opens CX with incorrect source page

https://gerrit.wikimedia.org/r/224853

santhosh triaged this task as Medium priority.
santhosh set Security to None.

We need a definition of what actually needs to be done in such a case.

If I translate an article from Geman to Catalan, I type "aklocpa" in Catalan, and I mark it as a red link, then when I click the red link, CX tries to load the article "aklocpa" from German, and it fails because such an article doesn't exist.

If we don't know what the source article is supposed to be, we need to show the article selector to the translator, with the target article pre-filled.

If we don't know what the source article is supposed to be

This is only for articles where we know the source article ("when clicking on a link you marked as missing"). In those cases, red links are generated from grey links that we know to which source article they correspond to.

For other cases (adding a new red link) we can even start without showing the action and keep improving later.

we can even start without showing the action

@Pginer-WMF, what action are you refering to?

we can even start without showing the action

@Pginer-WMF, what action are you refering to?

The basic idea is to let the user to start a new translation with the information that we have available.
For the case where the user creates a red link that did not existed in the source we can either:

  • A) Open the new translation dialog with the source and target languages, and target title prefilled, ready for the user to search the source article and start the translation.
  • B) Don't allow so start a new translation from the red link card for now (no clickable item and no tooltip).

I was referring to fix the issue for red links we know which article are they about (you can start a translation right away) and for the above edge case going with option B initially until there is time to fix it doing A (if everything could not be addressed in a single step).

Change 224853 abandoned by Santhosh:
Fix: Redlink in link card opens CX with incorrect source page

Reason:
Will take a look later.

https://gerrit.wikimedia.org/r/224853

santhosh removed a project: Patch-For-Review.
santhosh added a subscriber: santhosh.