Page MenuHomePhabricator

Graph extension should not use document.write for fallback image
Closed, DuplicatePublic

Description

document.write is used to write the graphoid output's img fallback tag; document.write should generally be avoided as it's notoriously flaky, and won't work in various circumstances where HTML data is being manipulated in unexpected ways...

I assume it's used to avoid loading the image when it won't be used because the JS is used instead, there hopefully is a better workaround somehow...

Event Timeline

brion created this task.Jul 15 2015, 6:39 PM
brion raised the priority of this task from to Needs Triage.
brion updated the task description. (Show Details)
brion added a subscriber: brion.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2015, 6:39 PM