Page MenuHomePhabricator

Remove WikibaseClient, WikibaseLib, WikibaseRepository and WikibaseView from git
Closed, DuplicatePublic

Description

Hi please delete WikibaseClient, WikibaseLib, WikibaseRepository and WikibaseView from git. The repo is located in the Wikibase repo. And these repos WikibaseClient, WikibaseLib and WikibaseRepository arnt being used last created 1 year and a half.

Event Timeline

Paladox raised the priority of this task from to Needs Triage.
Paladox updated the task description. (Show Details)
Paladox added a project: Wikidata.
Paladox added subscribers: Paladox, JanZerebecki, Krinkle, Legoktm.
Paladox renamed this task from Remove WikibaseClient, WikibaseLib and WikibaseRepository from git to Remove WikibaseClient, WikibaseLib, WikibaseRepository and WikibaseView from git.Jul 16 2015, 10:18 AM
Paladox updated the task description. (Show Details)

They are also empty and useless since they are in the wikibase repo.

The goal is to split those into separate repositories, that is why these were created.

Oh ok but woulden it be easer to just keep it under one repo. Since the extension may stop working properly. Do you have a timeline on this.

Change 225080 had a related patch set uploaded (by Paladox):
Add .gitreview

https://gerrit.wikimedia.org/r/225080

Mediawiki convention is to have one repo for each extension. Separate repos make it easier to properly modularize.
Which extension do you mean may stop working properly?
No timeline, but not anytime soon.

All three of them repo, client, lib. But I see now that it will be easer to fix issue making smaller commit which results in quicker review unless the patch requires changes to the other repo. I could start splitting them out Starting with client or lib since there smaller if you want.

Change 225086 had a related patch set uploaded (by Paladox):
Add tests for WikibaseRepository

https://gerrit.wikimedia.org/r/225086

Change 225087 had a related patch set uploaded (by Paladox):
Add support for running test this extension needs once it is being used

https://gerrit.wikimedia.org/r/225087

This comment was removed by Paladox.

Change 225086 had a related patch set uploaded (by Paladox):
Add tests for WikibaseRepository

https://gerrit.wikimedia.org/r/225086