Page MenuHomePhabricator
Create Task
Maniphest T106011

[AG] Story: Copying attribution with one click (plain text or html)
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

As a user I can to copy the attribution with one click as plain text into my clipboard so I can use it how I wish to.
As a user I can to copy the licence credit with one click in html format so I can add it to my blog.

*the text of the attribution is read-only
*make button background quickly flash three times between colours when copying

mockups

39.png (800×1 px, 146 KB)

39_doc.png (800×1 px, 164 KB)

Related Objects
Search...

Event Timeline

• KasiaWMDE created this task.Jul 16 2015, 1:24 PM
• KasiaWMDE raised the priority of this task from to Medium.
• KasiaWMDE updated the task description. (Show Details)
• KasiaWMDE added a project: Tool-Attribution-Generator.
• KasiaWMDE added subscribers: • KasiaWMDE, Tobi_WMDE_SW.
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptJul 16 2015, 1:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• KasiaWMDE renamed this task from [AG] Copying attribution with one click in different formats (plan, html) to [AG] Story: Copying attribution with one click in different formats (plan, html).Jul 16 2015, 1:25 PM
• KasiaWMDE set Security to None.
• KasiaWMDE moved this task from Incoming to Backlog on the Tool-Attribution-Generator board.
Ricordisamoa subscribed.Jul 16 2015, 2:49 PM
• KasiaWMDE moved this task from Incoming to Blocked by others on the TCB-Team (now WMDE-TechWish) board.Jul 16 2015, 6:16 PM
• KasiaWMDE renamed this task from [AG] Story: Copying attribution with one click in different formats (plan, html) to [AG] Story: Copying attribution with one click (plain text).Aug 19 2015, 2:39 PM
• KasiaWMDE updated the task description. (Show Details)
• KasiaWMDE edited a custom field.
• KasiaWMDE moved this task from Backlog to Release 2.0 on the Tool-Attribution-Generator board.Aug 19 2015, 2:49 PM
• KasiaWMDE added a project: Tool-Labs-tools-Attribution-Generator-Release-2.0.Sep 2 2015, 4:57 PM
• KasiaWMDE moved this task from Blocked by others to Community Wishlist on the TCB-Team (now WMDE-TechWish) board.Sep 3 2015, 11:00 AM
• KasiaWMDE added a parent task: T106016: [AG] Epic: Implement new dialoguepage.Oct 13 2015, 2:57 PM
• KasiaWMDE updated the task description. (Show Details)Oct 13 2015, 3:43 PM
• KasiaWMDE moved this task from Release 2.0 to Sprint ready on the Tool-Attribution-Generator board.Oct 16 2015, 11:20 AM
• KasiaWMDE renamed this task from [AG] Story: Copying attribution with one click (plain text) to [AG] Story: Copying attribution with one click (plain text or html).Oct 20 2015, 4:51 PM
• KasiaWMDE updated the task description. (Show Details)
• KasiaWMDE mentioned this in T116048: [AG] Task: Design for section "Fertig" of the dialogue.Oct 20 2015, 5:28 PM
• KasiaWMDE added a parent task: T116048: [AG] Task: Design for section "Fertig" of the dialogue.
• KasiaWMDE edited a custom field.Oct 21 2015, 12:46 PM
• KasiaWMDE updated the task description. (Show Details)Oct 21 2015, 1:09 PM
Tobi_WMDE_SW added a project: TCB-Team-Sprint-2015-11-11.Nov 10 2015, 3:23 PM
• KasiaWMDE moved this task from Sprint ready to Work in progress on the Tool-Attribution-Generator board.Nov 13 2015, 12:32 PM
Jakob_WMDE claimed this task.Nov 24 2015, 9:28 AM
Jakob_WMDE moved this task from Backlog to Doing on the TCB-Team-Sprint-2015-11-11 board.
Jakob_WMDE added a comment.Nov 24 2015, 10:18 AM

PR on github: https://github.com/wmde/Lizenzverweisgenerator/pull/136

Jakob_WMDE moved this task from Doing to Review on the TCB-Team-Sprint-2015-11-11 board.Nov 24 2015, 10:20 AM
Addshore closed this task as Resolved.Nov 24 2015, 3:43 PM
Addshore moved this task from Review to Done on the TCB-Team-Sprint-2015-11-11 board.
Addshore subscribed.
• KasiaWMDE added a comment.EditedNov 25 2015, 8:49 PM

@Jakob_WMDE @Addshore
I just tested it in Safari and Firefox on a Mac: the copy button flashed but didn't copy anything. Once I wanted to paste it into a doc (both using the usual cmd+v and "paste"), it didn't work.
On my windows laptop it copied in Chrome and Firefox but without the links and with large spaces before and after the attribution.

Ricordisamoa added a comment.Nov 25 2015, 8:53 PM
In T106011#1832407, @KasiaWMDE wrote:

I just tested it in Safari and Firefox: the copy button flashed but didn't copy anything. Once I wanted to paste it into a doc (both using ctrl+v and "paste"), it didn't work.

Please read about clipboard.js' browser support.

Tobi_WMDE_SW reopened this task as Open.Nov 26 2015, 11:29 AM
Tobi_WMDE_SW added a project: TCB-Team-Sprint-2015-11-25.

Reopening until issues are fixed.

Jakob_WMDE added a comment.Dec 1 2015, 11:51 AM

Yes, as @Ricordisamoa pointed out the currently supported browsers are Chrome 42+, Firefox 41+, IE 9+ and Opera 29+. Safari is not supported at all. We could either redo this using a different tool that supports Safari (I'm not sure there is one that doesn't use some Flash hacks) or at least fail with an error in case the text could not be copied.

Tobi_WMDE_SW added a comment.Dec 1 2015, 12:17 PM

@Jakob_WMDE best would probably be to not show the copy-button at all if it is not supported. Think that is doable, right?

Tobi_WMDE_SW added a comment.Dec 1 2015, 12:18 PM

the "large spaces problem" should be fixed, though.

Jakob_WMDE added a comment.Dec 1 2015, 3:17 PM

@Tobi_WMDE_SW I just looked into this briefly and for some reason it's not that easy to check if it's supported. The maintainer of the clipboard.js library explains it here: https://github.com/zenorocha/clipboard.js/issues/12
The easiest way would still be to just show an error. I agree though that not showing it at all would be better...

Tobi_WMDE_SW added a comment.Dec 2 2015, 3:00 PM

Ok, as just discussed in the meeting: Let's

  • invest an our looking for an alternative library
  • if there is no easy solution, let's go for "Show a hint to the user in case it's not possible to copy and give the advice to use CTRL+C. Additionally mark the text in the field already.
Jakob_WMDE moved this task from Backlog to Doing on the TCB-Team-Sprint-2015-11-25 board.Dec 3 2015, 2:26 PM
Jakob_WMDE moved this task from Doing to Review on the TCB-Team-Sprint-2015-11-25 board.Dec 3 2015, 3:02 PM

PR with zeroclipboard instead of clipboard.js https://github.com/wmde/Lizenzverweisgenerator/pull/159

Ricordisamoa added a comment.Dec 4 2015, 11:54 PM

Actually the Selection and execCommand APIs are so simple they can be used without any library.

In T106011#1848168, @Jakob_WMDE wrote:

PR with zeroclipboard instead of clipboard.js https://github.com/wmde/Lizenzverweisgenerator/pull/159

Flash? 😧

• KasiaWMDE moved this task from Backlog to In progress on the Tool-Labs-tools-Attribution-Generator-Release-2.0 board.Dec 7 2015, 12:57 PM
Tobi_WMDE_SW raised the priority of this task from Medium to High.Dec 9 2015, 2:51 PM
Tobi_WMDE_SW closed this task as Resolved.Jan 4 2016, 12:06 PM
Tobi_WMDE_SW moved this task from Community Wishlist to Done on the TCB-Team (now WMDE-TechWish) board.Jan 6 2016, 4:07 PM
Tobi_WMDE_SW moved this task from Work in progress to Done on the Tool-Attribution-Generator board.Jan 20 2016, 12:33 PM
Tobi_WMDE_SW moved this task from In progress to Done on the Tool-Labs-tools-Attribution-Generator-Release-2.0 board.Jan 27 2016, 10:02 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits