Page MenuHomePhabricator
Create Task
Maniphest T106039

AstroPay gateway not incrementing order ID in some circumstances
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

We should be sending a new order id (x_invoice) with every call to NewInvoice. This should be generated as ct_id.numAttempt.
There is logic to increment numAttempt and retry the api call every time we get a 'duplicate invoice' error message back, but in a lot of cases we seem to be repeatedly sending the same one.

Details

SubjectRepoBranchLines +/-
Generate new order IDs for each NewInvoice callmediawiki/extensions/DonationInterfacemaster+98 -13
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Jul 16 2015, 3:56 PM
Ejegg raised the priority of this task from to Needs Triage.
Ejegg updated the task description. (Show Details)
Ejegg added projects: [DO NOT USE] Astropay [superseded by #FR-Astropay], Fundraising-Backlog.
Ejegg subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2015, 3:56 PM
• atgo moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Jul 17 2015, 6:34 PM
Ejegg claimed this task.Jul 22 2015, 7:37 PM
Ejegg added a project: Fundraising Sprint The Pogues.
Ejegg set Security to None.
Ejegg edited a custom field.
• DStrine moved this task from Sprint +1 to Closed Sprint Work Q1 1516 on the Fundraising-Backlog board.Jul 22 2015, 7:40 PM
Ejegg added a comment.Jul 24 2015, 9:46 PM

Note to self: numAttempt only gets incremented when you set a final status. Either the AstroPay adapter will have to redefine what numAttempt means (and increment it every time we call NewInvoice), or it will have to do something else to make the invoice ID unique

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint The Pogues board.Jul 24 2015, 10:09 PM
gerritbot subscribed.Jul 27 2015, 6:19 PM

Change 227256 had a related patch set uploaded (by Ejegg):
Generate new order IDs for each NewInvoice call

https://gerrit.wikimedia.org/r/227256

gerritbot added a project: Patch-For-Review.Jul 27 2015, 6:19 PM
Ejegg moved this task from Doing to Review on the Fundraising Sprint The Pogues board.Jul 27 2015, 6:20 PM
gerritbot added a comment.Jul 27 2015, 11:44 PM

Change 227256 merged by jenkins-bot:
Generate new order IDs for each NewInvoice call

https://gerrit.wikimedia.org/r/227256

Ejegg mentioned this in rMEXTc25840ba28ae: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Jul 27 2015, 11:44 PM
awight mentioned this in rEDOI8205cfbbcc22: Generate new order IDs for each NewInvoice call.Jul 27 2015, 11:44 PM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint The Pogues board.Jul 27 2015, 11:54 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint The Pogues board.Jul 28 2015, 4:17 PM
Ejegg closed this task as Resolved.Jul 28 2015, 8:01 PM
• atgo moved this task from Backlog to Done on the [DO NOT USE] Astropay [superseded by #FR-Astropay] board.Aug 5 2015, 9:39 PM
• DStrine added a project: Essential-Work.Aug 27 2015, 4:44 PM
• DStrine added a project: FR-dlocal.Dec 14 2015, 7:15 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptDec 14 2015, 7:15 PM
• Phabricator_maintenance removed a project: [DO NOT USE] Astropay [superseded by #FR-Astropay].Aug 10 2016, 11:47 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL