Page MenuHomePhabricator
Create Task
Maniphest T106053

Parse AstroPay error codes / description and display appropriate messages to donor
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

AstroPay gateway currently shows one generic error message no matter what went wrong with the NewInvoice call (except duplicate invoice, which also needs investigating). We should recognize the rest of the errors and give the donor some information that can help them successfully donate.

We saw these during our test:

  • User unauthorized
  • Empty param x_cpf (This should be mandatory - how did we let this through?)
  • Invalid control
  • Could not register user
  • The user limit has been exceeded
  • User unauthorized due to cadastral situation

Details

SubjectRepoBranchLines +/-
Log unrecognized AstroPay errors at 'error' levelmediawiki/extensions/DonationInterfacemaster+3 -0
Parse more of AstroPay's error descriptionsmediawiki/extensions/DonationInterfacemaster+152 -23
Check error['context'] to place error messagesmediawiki/extensions/DonationInterfacemaster+5 -3
Use old error forms for AstroPay fail pagemediawiki/extensions/DonationInterfacemaster+7 -3
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Jul 16 2015, 4:43 PM
Ejegg raised the priority of this task from to Needs Triage.
Ejegg updated the task description. (Show Details)
Ejegg added projects: [DO NOT USE] Astropay [superseded by #FR-Astropay], Fundraising-Backlog.
Ejegg subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2015, 4:43 PM
Ejegg added a comment.Jul 16 2015, 5:48 PM

Here's the full dump of possible responses provided by AstroPay:

{"status":"1","desc":"Empty param x_login"}
{"status":"1","desc":"The user must be adult"}
{"status":"1","desc":"User unauthorized due to cadastral situation"}
{"status":"1","desc":"Invoice already used"}
{"status":"1","desc":"Payment method not found"}
{"status":"1","desc":"Empty param x_cpf"}
{"status":"1","desc":"Invalid param x_cpf","error_code":"300"}
{"status":"1","desc":"User blacklisted","error_code":"503"}
{"status":"1","desc":"Invalid credentials"}
{"status":"1","desc":"Currency not allowed for this country"}
{"status":"1","desc":"The user limit has been exceeded"}
{"status":"1","desc":"User unauthorized"}
{"status":"1","desc":"Invalid param x_bdate"}
{"status":"1","desc":"User unauthorized","error_code":"502"}
{"status":"1","desc":"Empty param x_bank"}
{"status":"1","desc":"Payment method not found","error_code":"506"}
{"status":"1","desc":"Empty param x_cpf","error_code":"301"}
{"status":"1","desc":"User blacklisted"}
{"status":"1","desc":"Unregistered IP address"}
{"status":"1","desc":"User unauthorized due to cadastral situation","error_code":"504"}
{"status":"1","desc":"Empty param x_trans_key"}
{"status":"1","desc":"Empty param x_invoice"}
{"status":"1","desc":"Unregistered IP address","error_code":"402"}
{"status":"1","desc":"Invalid param x_email"}
{"status":"1","desc":"Empty param x_amount"}
{"status":"1","desc":"Invalid control"}
{"status":"1","desc":"Could not register user"}
{"status":"1","desc":"The user limit has been exceeded."}
{"status":"1","desc":"Empty param x_iduser"}
{"status":"1","desc":"Empty param control"}
{"status":"1","desc":"Empty param x_iduser","error_code":"301"}
{"status":"1","desc":"Empty param x_login","error_code":"301"}
{"status":"1","desc":"Currency not allowed for this country","error_code":"601"}
{"status":"1","desc":"Invalid param x_amount"}
{"status":"1","desc":"The user limit has been exceeded","error_code":""}
{"status":"1","desc":"Invalid param x_amount","error_code":"300"}
{"status":"1","desc":"The user must be adult","error_code":"501"}
{"status":"1","desc":"Invalid param x_bdate","error_code":"300"}
{"status":"1","desc":"Could not register user","error_code":"700"}
{"status":"1","desc":"Invoice already used","error_code":"500"}
{"status":"1","desc":"Empty param x_bank","error_code":"301"}
{"status":"1","desc":"Empty param x_trans_key","error_code":"301"}
{"status":"1","desc":"Invalid control","error_code":"302"}
{"status":"1","desc":"Invalid credentials","error_code":"401"}
{"status":"1","desc":"Empty param x_amount","error_code":"301"}
• atgo moved this task from Triage to Sprint +3 on the Fundraising-Backlog board.Jul 17 2015, 6:34 PM
• atgo moved this task from Sprint +3 to Sprint +1 on the Fundraising-Backlog board.
Ejegg added a project: Fundraising Sprint The Pogues.Jul 22 2015, 7:38 PM
Ejegg set Security to None.
Ejegg edited a custom field.
• DStrine moved this task from Sprint +1 to Closed Sprint Work Q1 1516 on the Fundraising-Backlog board.Jul 22 2015, 7:39 PM
Ejegg claimed this task.Jul 23 2015, 11:37 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint The Pogues board.
Ejegg updated the task description. (Show Details)
gerritbot subscribed.Jul 23 2015, 11:39 PM

Change 224546 had a related patch set uploaded (by Ejegg):
WIP Parse more of AstroPay's error descriptions

https://gerrit.wikimedia.org/r/224546

gerritbot added a project: Patch-For-Review.Jul 23 2015, 11:39 PM
gerritbot added a comment.Jul 24 2015, 9:16 PM

Change 226917 had a related patch set uploaded (by Ejegg):
Use old error forms for AstroPay fail page

https://gerrit.wikimedia.org/r/226917

gerritbot added a comment.Jul 24 2015, 9:24 PM

Change 226920 had a related patch set uploaded (by Ejegg):
Check error['context'] to place error messages

https://gerrit.wikimedia.org/r/226920

Ejegg added a comment.Jul 24 2015, 10:08 PM

We only saw 'invalid control' errors for users who put spaces in their fiscal number. Maybe those spaces were stripped on AstroPay's side before calculating the signature? Our new fiscal number validation should stop that. If we continue to get 'invalid control' I will investigate our signing process.

This patch should deal with the rest of the errors we actually saw in our test, though there are plenty more in the provided list.

Additionally , I updated the price ceiling in AstroPay settings to reflect our agreed transaction limit, which should stop some of the 'limit exceeded' errors at validation.

Ejegg moved this task from Doing to Review on the Fundraising Sprint The Pogues board.Jul 24 2015, 10:08 PM
gerritbot added a comment.Jul 27 2015, 11:49 PM

Change 226917 merged by jenkins-bot:
Use old error forms for AstroPay fail page

https://gerrit.wikimedia.org/r/226917

Ejegg mentioned this in rMEXT2dc6f83809d8: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Jul 27 2015, 11:49 PM
awight mentioned this in rEDOIea35c3e3a314: Use old error forms for AstroPay fail page.Jul 27 2015, 11:49 PM
gerritbot added a comment.Jul 27 2015, 11:50 PM

Change 226920 merged by jenkins-bot:
Check error['context'] to place error messages

https://gerrit.wikimedia.org/r/226920

awight mentioned this in rEDOI3b868b0f4cfd: Check error['context'] to place error messages.Jul 27 2015, 11:50 PM
Ejegg mentioned this in rMEXT360e4631b62f: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Jul 27 2015, 11:50 PM
gerritbot added a comment.Jul 28 2015, 12:08 AM

Change 224546 merged by jenkins-bot:
Parse more of AstroPay's error descriptions

https://gerrit.wikimedia.org/r/224546

Ejegg mentioned this in rMEXT46587ee28715: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Jul 28 2015, 12:08 AM
awight mentioned this in rEDOI1afab3efe512: Parse more of AstroPay's error descriptions.Jul 28 2015, 12:08 AM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint The Pogues board.Jul 28 2015, 12:12 AM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint The Pogues board.Jul 28 2015, 4:17 PM
Ejegg closed this task as Resolved.Jul 28 2015, 8:01 PM
gerritbot added a comment.Jul 28 2015, 8:31 PM

Change 227571 had a related patch set uploaded (by Ejegg):
Log unrecognized AstroPay errors at 'error' level

https://gerrit.wikimedia.org/r/227571

gerritbot added a comment.Jul 28 2015, 9:56 PM

Change 227571 merged by jenkins-bot:
Log unrecognized AstroPay errors at 'error' level

https://gerrit.wikimedia.org/r/227571

Ejegg mentioned this in rEDOIf93673cb75ef: Log unrecognized AstroPay errors at 'error' level.Jul 30 2015, 10:11 PM
Ejegg mentioned this in rMEXT59f235c0c162: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Jul 30 2015, 10:16 PM
• atgo moved this task from Backlog to Done on the [DO NOT USE] Astropay [superseded by #FR-Astropay] board.Aug 5 2015, 9:39 PM
• DStrine edited a custom field.Aug 18 2015, 3:36 PM
• DStrine edited a custom field.Aug 18 2015, 5:26 PM
• DStrine added a project: OKR-Work.Aug 25 2015, 9:09 PM
• DStrine added a project: FR-dlocal.Dec 14 2015, 7:15 PM
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptDec 14 2015, 7:15 PM
• Phabricator_maintenance removed a project: [DO NOT USE] Astropay [superseded by #FR-Astropay].Aug 10 2016, 11:47 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL