Page MenuHomePhabricator

add tracking category for imagemap errors. add imagemap tag to the prop list for "Special:PagesWithProp"
Open, LowPublic

Description

basically, whenever imagemap displays an error message (any system message whose name begins
"imagemap_(bad|invalid|no|missing|polly_odd|unrecognised)" ), the page should be added to some tracking category.

a second, unrelated request lumped into this item: create a new prop value with PagesWithProp for pages with imagemap, similar to "score".

peace.

Event Timeline

Kipod created this task.Jul 16 2015, 7:00 PM
Kipod raised the priority of this task from to Needs Triage.
Kipod updated the task description. (Show Details)
Kipod added a project: ImageMap.
Kipod added a subscriber: Kipod.
Restricted Application added a project: Multimedia. · View Herald TranscriptJul 16 2015, 7:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
IKhitron set Security to None.Jul 23 2015, 2:38 PM
IKhitron added a subscriber: IKhitron.
Restricted Application added a subscriber: Matanya. · View Herald TranscriptJul 23 2015, 2:38 PM
Jdforrester-WMF triaged this task as Low priority.Sep 4 2015, 6:55 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:59 PM

Change 324722 had a related patch set uploaded (by FreedomFighterSparrow):
Add a page prop and a tracking category for errors

https://gerrit.wikimedia.org/r/324722

Anybody wants to review this? Basically I just copied stuff over from extension:Score, even though there's no indication if their way is the recommended one.

Hi, @FreedomFighterSparrow. What's new after the review?

@IKhitron, nothing new, and I'm sorry to say this is usually what happens when I try to make small contributions - I have no idea how to attract +2 commiters to them... and I believe ImageMap has no specific ownership I'll try adding @Tgr as a reviewer, since he is the only listed member in the ImageMap project on Phabricator.

Thank you, @FreedomFighterSparrow, but as I know there were problems in the review you already get from the reviewer I found for you. Did you fix them? Thank you.

Eran's comments? Yeah, a long time ago. You can see everything looking at
the change (https://gerrit.wikimedia.org/r/#/c/324722/).

Great, thanks!

Hello, @Aklapper. Is there something to do, when the developer disappears in the middle of the second review? Thank you.

I don't know what you refer to ("second review"?), sorry. See my previous comment for contact information - thanks!

I saw it, but this is something different. I don't how else I can say second review. "There was first review, and this is the next"? I'm sure you know what is second and what is review, so this will not help.

Hello, @Aklapper. Is there something to do, when the developer disappears in the middle of the second review? Thank you.

Sometimes people get busy or have other things. If you need help getting a patch reviewed, you can try asking on MediaWiki-General irc channel. I'll try and look at this patch later on today.

@IKhitron, I'm still around. I just did not have the time to deal with @Tgr's review, as I did this fix as a distraction, and according to the best practices I could find (as in, copied everything from extension:Score, assuming what was good enough for one deployed extension would be good for another). I probably need to rollback the exceptions I added, and that's it.

Thank you both.

@IKhitron, I did quite a bit of work on this, even though this isn't really relevant to me (I don't even use this extension myself). I fixed each and every one of @Tgr's comments since the last time you pushed for this. @eranroz did a +1 review, but I have no way of forcing someone to actually go through a +2 review. It also seems some work was done on this extension since then, which requires a proper rebase - I think I'm done for now.

I see. A pity. Thank you.

Restricted Application added a project: Multimedia. · View Herald TranscriptApr 12 2018, 7:29 PM

(Assigning for multimedia team for review)

Cparle claimed this task.Apr 23 2018, 4:37 PM
Cparle added a subscriber: Cparle.

Will try to get a code review in on this this week

Cparle removed Cparle as the assignee of this task.Jun 18 2018, 4:30 PM

Hi @FreedomFighterSparrow - seeing as it looks like you're ok with implementing @Bawolff 's suggestion, is it ok if I assign this back to you?