| • Niedzielski | |
| Jul 16 2015, 7:28 PM |
| F8997959: main-MainActivity-08092017162849.png | |
| Aug 9 2017, 2:29 PM |
| F193607: screenshot-2015-07-16-13-23-15-422565192.png | |
| Jul 16 2015, 7:28 PM |
Background is dark.
Background is light.
App version: 6637c5f2def55db5fc44b1d3b291f6f1eee0d9cf
Android OS versions: API 22
Device model: emulator
Device language: English
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Correctly render explicit background color in ZoomableDraweeView. | apps/android/wikipedia | master | +57 -14 |
Note: this is because we explicitly set the background to white for PNG and SVG images. I've tried to look for a solution where we set only the image boundary to white (while preserving the rest of the background as dark), but haven't had any luck
@Dbrant, maybe we can just make the ImageView height wrap_content and set the parent background to dark.
@Niedzielski But that wouldn't play well with the PhotoView library that provides the zoom & pan functionality. It expects the ImageView to be match_parent.
@Dbrant, hm maybe we can build a LayerListDrawable with a ColorDrawable in the background and a a BitmapDrawable on top, then set the ImageView src to use the Drawable.
Change 368827 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Correctly render explicit background color in ZoomableDraweeView.
Change 368827 merged by jenkins-bot:
[apps/android/wikipedia@master] Correctly render explicit background color in ZoomableDraweeView.
Tested on a Nexus 4 with Android 5.1 and a Pixel with Android 7.1.1
This looks good for me. I tried the example article and a few others.
